-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add encoding / decoding for bytes[CompactBytesArray]
#261
Conversation
Co-authored-by: b00ste.lyx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. May be review the comment about empty bytes arrays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack some bytes know how here but lgtm. Please update the docs too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too,
Very clear and easy to read code Thank you!
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
+ Coverage 81.83% 83.02% +1.18%
===========================================
Files 15 18 +3
Lines 914 978 +64
Branches 200 218 +18
===========================================
+ Hits 748 812 +64
- Misses 90 91 +1
+ Partials 76 75 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: b00ste.lyx [email protected]
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
⭐ feature
What is the current behaviour (you can also link to an open issue here)?
There is currently no support for encoding
CompactBytesArray
defined in LSP2.Related to issue #252
What is the new behaviour (if this is a feature change)?
Add basic support for
bytes[CompactBytesArray]
Other information: