Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Account and Character Based Expansion Settings #4598

Closed
wants to merge 2 commits into from

Conversation

Kinglykrab
Copy link
Contributor

Description

  • Adds the ability to limit expansions on an account or character basis.

Type of change

  • New feature
  • This change requires a documentation update

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur
  • If my changes make database schema changes, I have tested the changes on a local database (attach image). Updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version. (Delete this if not applicable)

@Akkadius
Copy link
Member

Have a few things for this in the next few days

@Akkadius
Copy link
Member

I think for this we should use data buckets.

We already have account / client flagging built into caching so I am far more comfortable for us leveraging buckets for this. We also already have quest hooks for all of this so we get many things for free.

#4603

@Kinglykrab
Copy link
Contributor Author

I think for this we should use data buckets.

We already have account / client flagging built into caching so I am far more comfortable for us leveraging buckets for this. We also already have quest hooks for all of this so we get many things for free.

#4603

Works for me.

@Kinglykrab Kinglykrab closed this Jan 21, 2025
@Kinglykrab Kinglykrab deleted the feature/account_character_expansions branch January 21, 2025 21:57
@Kinglykrab Kinglykrab restored the feature/account_character_expansions branch January 22, 2025 22:58
@Kinglykrab Kinglykrab reopened this Jan 22, 2025
@Kinglykrab Kinglykrab closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants