Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Databuckets] Improved Reliability and Performance of Databuckets #4562

Merged
merged 15 commits into from
Dec 12, 2024
Merged

[Databuckets] Improved Reliability and Performance of Databuckets #4562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6cb361d
[Databuckets] Don't broadcast client-scoped updates
Akkadius Nov 18, 2024
354a80b
Remove temp feature flag
Akkadius Nov 29, 2024
e88de4c
Remove distributed caching, only cache for character scoped data, sim…
Akkadius Dec 6, 2024
8ca451d
Update bot.cpp
Akkadius Dec 6, 2024
db1cf81
Cleanup
Akkadius Dec 6, 2024
d3b3239
Update data_bucket.cpp
Akkadius Dec 6, 2024
00467c0
Cleanup
Akkadius Dec 6, 2024
eff8b57
Cleanup
Akkadius Dec 6, 2024
ec038fb
Remove BulkLoadEntities from LoadNPCTypes
Akkadius Dec 6, 2024
9d04b0d
Update data_bucket.cpp
Akkadius Dec 6, 2024
b73fb33
Cleanup
Akkadius Dec 8, 2024
cd7f1bc
More cleanup
Akkadius Dec 8, 2024
5bb8789
More cleanup
Akkadius Dec 8, 2024
0fea0a9
BulkLoadEntities to BulkLoadEntitiesToCache
Akkadius Dec 8, 2024
ece963e
Add CanCache in DeleteData to gate an unnecessary call
Akkadius Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions common/servertalk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,6 @@
// player events
#define ServerOP_PlayerEvent 0x5100

#define ServerOP_DataBucketCacheUpdate 0x5200

enum {
CZUpdateType_Character,
CZUpdateType_Group,
Expand Down
5 changes: 0 additions & 5 deletions world/zoneserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,11 +1564,6 @@ void ZoneServer::HandleMessage(uint16 opcode, const EQ::Net::Packet &p) {
DynamicZone::HandleZoneMessage(pack);
break;
}
case ServerOP_DataBucketCacheUpdate: {
zoneserver_list.SendPacket(pack);

break;
}
case ServerOP_GuildTributeUpdate: {
auto data = (GuildTributeUpdate *)pack->pBuffer;
auto guild = guild_mgr.GetGuildByGuildID(data->guild_id);
Expand Down
1 change: 1 addition & 0 deletions zone/bot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3089,6 +3089,7 @@ bool Bot::Spawn(Client* botCharacterOwner) {
m_targetable = true;
entity_list.AddBot(this, true, true);

ClearDataBucketCache();
DataBucket::GetDataBuckets(this);
LoadBotSpellSettings();
if (!AI_AddBotSpells(GetBotSpellID())) {
Expand Down
2 changes: 1 addition & 1 deletion zone/client_packet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ int Client::HandlePacket(const EQApplicationPacket *app)
// Finish client connecting state
void Client::CompleteConnect()
{

UpdateWho();
client_state = CLIENT_CONNECTED;
SendAllPackets();
Expand Down Expand Up @@ -1413,6 +1412,7 @@ void Client::Handle_Connect_OP_ZoneEntry(const EQApplicationPacket *app)
drakkin_details = m_pp.drakkin_details;

// Load Data Buckets
ClearDataBucketCache();
DataBucket::GetDataBuckets(this);

// Max Level for Character:PerCharacterQglobalMaxLevel and Character:PerCharacterBucketMaxLevel
Expand Down
Loading