[Bug Fix] Depop Charm Pet and Detach Debuffs on Evacuate #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
reviewed
Jan 7, 2024
Kinglykrab
reviewed
Jan 7, 2024
|
I am honestly unsure, I can rule is off for safety (I haven't played on live in eons) |
What kind of issues could this cause if it went in as-is? Just removes effects from NPC on zone? |
Kinglykrab
approved these changes
Jan 7, 2024
This will depop charm pets and deteach debuffs to prevent some social aggro issues and exploitable conditions with charming and pulling a mob across the zone with no aggro concerns.
Kinglykrab
force-pushed
the
feat/detach_debuffs_on_evac
branch
from
2ed479a
to
1d3a9c7
Compare
Kinglykrab
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will clear charm from charm pets and deteach debuffs to prevent some social aggro issues and exploitable conditions with charming and pulling a mob across the zone with no aggro concerns.