Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Character] Convert Delete/Load/Remove/Save of Character AA to Repositories #3849

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

Kinglykrab
Copy link
Contributor

Notes

  • Convert DeleteCharacterAAs, LoadAlternateAdvancement, RemoveExpendedAA and SaveAA to repositories.
  • Add AACategory namespace for AA Categories.
  • Cleanup some logic/formatting in modified methods.

Images

Load

image
image

Delete

image
image

Save

image
image

common/eq_constants.h Outdated Show resolved Hide resolved
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, lgtm

…tories

- Convert `DeleteCharacterAAs`, `LoadAlternateAdvancement`, `RemoveExpendedAA` and `SaveAA` to repositories.
- Add `AACategory` namespace for AA Categories.
- Cleanup some logic/formatting in modified methods.
@Kinglykrab Kinglykrab force-pushed the character/deleteloadremovesave_character_aa branch from c11e7d4 to 1a43e06 Compare January 7, 2024 05:29
@Akkadius Akkadius merged commit fd787af into master Jan 7, 2024
0 of 2 checks passed
@Akkadius Akkadius deleted the character/deleteloadremovesave_character_aa branch January 7, 2024 05:30
@Akkadius Akkadius mentioned this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants