Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update layers group validation #1239

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented Sep 3, 2024

Implemented changes

  • Array validation was not included inside the Group's layer validator. Updated validator code as per array

Screenshots/Videos

Screenshot 2024-09-03 at 2 11 14 PM

Checklist before requesting a review

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit ef230cc
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/66d6cb46c9541e00083756a6
😎 Deploy Preview https://deploy-preview-1239--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@srijitcoder srijitcoder marked this pull request as ready for review September 3, 2024 08:42
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing integration of dev package solves issue, looks good, thank you!

@silvester-pari silvester-pari merged commit 2d3af34 into main Sep 9, 2024
8 checks passed
@silvester-pari silvester-pari deleted the storytelling/fix/validatoe-layers branch September 9, 2024 11:20
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants