update dependencies #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 6, 2019 18:09
…atible code, failed
| @@ -15,7 +15,7 @@ const ecc = require('eosjs-ecc') | |||
|
|
|||
| # Include | |||
|
|
|||
| - Install with: `npm install eosjs-ecc` | |||
| - Install with: `yarn add eosjs-ecc` | |||
There was a problem hiding this comment.
why this change? Also below you tell them to use yarn . Can't a user use either yarn OR npm, also I thought we were sticking with yarn for OSS.
There was a problem hiding this comment.
Yes, a user can use either but we are making the change over to yarn in all of our documentation.
tbfleming
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing security vulnerabilities by updating and locking all dependencies
Switched to yarn
Steps to ensure compatibility:
any other ideas/suggestions for compatibility testing is much appreciated; we want to ensure this works for everyone before merging