Merge develop into kv-database

[arhag]

Change Description

This PR merges the develop branch (with the new host function system introduced in PR #8868) into kv-database.

It ports all of the intrinsics introduced in PR #8223 to the new host function system.

The new host function system revealed that the test wast code in the kv_tests/notify unit test was aliasing the key and value spans in calls to the kv_set intrinsic. The test wast code has been modified to avoid aliasing.

This PR also includes fixes to a couple of additional bugs that were introduced in PR #8868 (one in webassembly/preconditions.hpp and one in webassembly/common.hpp):

diff --git a/libraries/chain/include/eosio/chain/webassembly/preconditions.hpp b/libraries/chain/include/eosio/chain/webassembly/preconditions.hpp
index 42eb44ba5..75564b468 100644
--- a/libraries/chain/include/eosio/chain/webassembly/preconditions.hpp
+++ b/libraries/chain/include/eosio/chain/webassembly/preconditions.hpp
@@ -127,7 +127,7 @@ namespace eosio { namespace chain { namespace webassembly {
             }
             if constexpr (is_span_type_v<arg_t> || vm::is_argument_proxy_type_v<arg_t>) {
                eosio::vm::invoke_on<false, eosio::vm::invoke_on_all_t>([&](auto&& narg, auto&&... nrest) {
-                  using nested_arg_t = std::decay_t<decltype(arg)>;
+                  using nested_arg_t = std::decay_t<decltype(narg)>;
                   if constexpr (eosio::vm::is_span_type_v<nested_arg_t> || vm::is_argument_proxy_type_v<arg_t>)
                       EOS_ASSERT(!is_aliasing(detail::to_span(arg), detail::to_span(narg)), wasm_exception, "pointers not allowed to alias");
                }, rest...);

diff --git a/libraries/chain/include/eosio/chain/webassembly/common.hpp b/libraries/chain/include/eosio/chain/webassembly/common.hpp
index 14fa9bbed..393fd385a 100644
--- a/libraries/chain/include/eosio/chain/webassembly/common.hpp
+++ b/libraries/chain/include/eosio/chain/webassembly/common.hpp
@@ -74,7 +74,7 @@ namespace eosio { namespace chain {
       template <typename T>
       auto from_wasm(void* ptr) const
          -> std::enable_if_t< std::is_pointer_v<T>,
-                              vm::argument_proxy<std::remove_pointer_t<T>>> {
+                              vm::argument_proxy<T> > {
          validate_pointer<std::remove_pointer_t<T>>(ptr, 1);
          return {ptr};
       }

I recommend using the following diff to review the relevant changes (excluding the parts that just bring in code changes that were already merged into develop).

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

[swatanabe-b1]

The alias check is asymmetric. These should not be considered to alias.

[swatanabe-b1]

Will handle this in kv-database.