This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fixes for multi-node testing with the test.system contract #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.system contract: * authentication keys were defaulting to the first producer key on a node if none was explicitly set however, the method of deriving this required that producer to be "active" creating a race condition for starting up a candidate producer node * `get_scheduled_producer` was not taking `config::producer_repititions` into account properly with its math, it is likely that we never had all of the producers working before * the ABI for `test.system` was not properly serializable for `setprods`
heifner
approved these changes
Feb 27, 2018
| if(pp != nullptr && pp->get_state() == abstract_plugin::started) | ||
| return pp->first_producer_public_key(); | ||
| return pp->first_producer_public_key();*/ |
There was a problem hiding this comment.
Seems to me we should make peer-private-key required so that private_keys is never empty. I think you are fine to remove this code for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_scheduled_producerwas not takingconfig::producer_repititionsinto account properly with its math, it is likely that we never had all of the producers working beforetest.systemwas not properly serializable forsetprods