This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix multiversion test failure - merge 2.1.x #10054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The multiversion unit test is fixed to resolve occasional test failures, which mainly occurred at three checking points:
Nodes are not in sync before preactivation
after the testing cluster is launched. To fix this,areNodesInSync
method adds a waiting time when checking if nodes are in sync.1st node should contain PREACTIVATE FEATURE
after the 1st node tries to activate preactivate feature. The fix adds retries to activate the feature and then check its status.1st node should be out of sync with the rest nodes
after the 1st node has activated the preactivate feature. This is fixed by not resuming (and then re-pausing) all nodes until the sync check is finished.Thank @brianjohnson5972 for the help.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions