Simple multi line support #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle line into "virtual" lines by ";"
…that and just failes parsing
…char is in comment. And add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting it out there. I think this is one of the best solutions to enable basic multilien support for different definitions and comments. Also supports to some extend multiple definitions per line.
I think the only "really" better way would be to switch the parser in its entirety like the milestones/v1.8 branch.
Still think this solution could solve some problems.
Basically this parser uses the nextlineprovider to split lines based on the prefixes for definitions.
it searches for line termiantions ";" or new lines to split definitions.
Basically for what it is its doing a good job. I also fixed some stuff that was criticized when we talked about this in one issue.
The line number when an error occures is now pretty accurate. About the same as the vector candb++ errors which might also be one line off at some points.
Missing ";" are not longer fixed as that is not done by candb++ which failes parsing if a required ; is not present.