Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ValueTableLineParser to handle the case of (number " ") without… #55

Merged

Conversation

Werewolfkiss
Copy link

… breaking the quotes onto multiple lines and then failing to build a dictionary after.

Before this change

72 "H" 33 "!" 32 " " ;
Gets broken up into
72 "H"
33 "!"
32 "
"
Instead of what it should be:
72 "H"
33 "!"
32 " "

… breaking the quotes onto multiple lines and then failing to build a dictionary after.
@Whitehouse112
Copy link
Contributor

Hi @Werewolfkiss,
thanks for spot the issue and thanks for your PR, a similar issue has been point out in #57.
I took your solution as a starting point and:

  • used regex also in ToDictionary() extended method
  • added some tests

Feel free to review and comment our PR. The fix will be available in the next release.

Thanks again,
Regards

@Adhara3 Adhara3 merged commit d0f6829 into EFeru:main Oct 31, 2023
1 check failed
@Adhara3
Copy link
Collaborator

Adhara3 commented Nov 1, 2023

I had to revert the merge, a test was failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants