Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftPM section in Readme #99

Merged
merged 3 commits into from
Oct 11, 2020
Merged

Update SwiftPM section in Readme #99

merged 3 commits into from
Oct 11, 2020

Conversation

wacumov
Copy link
Contributor

@wacumov wacumov commented Oct 10, 2020

Modern versions of SwiftPM do not understand the old syntax (.Package and Version).

@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #99 into master will decrease coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   58.45%   56.87%   -1.59%     
==========================================
  Files          14       16       +2     
  Lines         857      895      +38     
==========================================
+ Hits          501      509       +8     
- Misses        356      386      +30     
Impacted Files Coverage Δ
Source/CIColor+.swift 77.77% <0.00%> (-22.23%) ⬇️
Source/CIImage+.swift 63.63% <0.00%> (-4.11%) ⬇️
Source/CGColor+.swift 37.50% <0.00%> (-3.41%) ⬇️
Source/CGImage+.swift 28.57% <0.00%> (-0.65%) ⬇️
Source/UIColor+.swift 9.52% <0.00%> (ø)
Source/UIImage+.swift 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62eff30...e2539a2. Read the comment docs.

@ApolloZhu
Copy link
Member

ApolloZhu commented Oct 10, 2020

Other options (CocoaPods / Carthage) uses ~>, which means "up to next major minor". @wacumov could you please change SPM to use that same behavior as well?

@EyreFree EyreFree merged commit 52248eb into EFPrefix:master Oct 11, 2020
@EyreFree
Copy link
Member

@wacumov

Thanks for your contribution, 🙏

ApolloZhu pushed a commit that referenced this pull request Nov 4, 2020
* Update SwiftPM section in Readme

* Update README.md

* Update SwiftPM section in README_CN too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants