ci: use rust-lld for all release targets #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency on gcc-based cross-compilation toolchain.
Collaborator
Author
|
I have tested the binaries produced with these PRs on the Orbic and host machines successfully. It could help to have a TPLink user test them. edit: works on tplink! and alcatel mw43. |
oopsbagel
commented
Apr 21, 2025
| linker = "rust-lld" | ||
| rustflags = ["-C", "target-feature=+crt-static"] | ||
|
|
||
| [target.armv7-unknown-linux-gnueabihf] |
Collaborator
Author
There was a problem hiding this comment.
Included to not break anyone's existing setups, but no longer used by github actions, make.sh, or tools/devenv.
This was referenced Apr 21, 2025
Closed
Collaborator
|
incredibly helpful, thanks again oops! |
wgreenberg
approved these changes
Apr 25, 2025
Collaborator
wgreenberg
left a comment
wgreenberg
left a comment
There was a problem hiding this comment.
verified it builds/runs on an Orbic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve "I can't build on $platform".
Removes dependency on gcc-based cross-compilation toolchain.
This branch allows development on any machine that can install rustup toolchains. No special debian packages are needed to build any of the binaries, only what's installed by rustup.
Updates
.cargo/config.toml,make.sh, tools/devenv, github actions, and the README to use the musl/rust-lld targets.Pull Request Checklist
cargo fmt