Surrogates (fixes #400) #935
Conversation
Chrome currently produces the following warning in dev console: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
| require.scopes.surrogatedb = (function() { | ||
|
|
||
| const hostnames = { | ||
| 'www.google-analytics.com': [ |
There was a problem hiding this comment.
This data structure should be better commented.
| ], | ||
| }; | ||
|
|
||
| const surrogates = { |
There was a problem hiding this comment.
More documentation needed here as well.
| function getSurrogateURI(script_url, script_hostname) { | ||
| // do we have an entry for the script hostname? | ||
| if (db.hostnames.hasOwnProperty(script_hostname)) { | ||
| const hosts = db.hostnames[script_hostname]; |
| // do any of the pattern tokens for that hostname match the script URL? | ||
| for (let i = 0; i < hosts.length; i++) { | ||
| const token = hosts[i]; | ||
| if (script_url.endsWith(token)) { |
There was a problem hiding this comment.
Handle query strings e.g.
ga.com/ga.js?foo=bar
|
|
||
| test("surrogate script URL lookups", function() { | ||
| // URLs that should have a surrogate | ||
| ok(!!getSurrogateURI('http://www.google-analytics.com/ga.js', 'www.google-analytics.com')); |
There was a problem hiding this comment.
Test for no surrogate?
Test other surrogates...
There was a problem hiding this comment.
test that query strings are handled in a sane way
ghostwords
force-pushed
the
surrogates
branch
from
3b8cd35
to
a88a76a
Compare
Still needs to be moved to dedicated testing page: #928.
So that it can get auto collected.
Conflicts: src/webrequest.js
Conflicts: src/webrequest.js
Conflicts: src/webrequest.js
More controlled, more reliable, faster. Related to #928.
|
@cooperq OK, should be good to merge now. Take a look please.
|
|
@gunesacar Let me know if you have any suggestions to improve the script surrogates integration test. |
Conflicts: src/background.js src/domainExceptions.js src/webrequest.js tests/index.html
|
Looks good to me! |
It looks pretty good to me. Maybe you could consider adding a test for outbound link tracking: |
ghostwords
added
the
surrogates
WIP pull request for #400
Besides review, what's left is more surrogates and more testing. We should run some queries against the "report broken site" db to get some recent high-profile breakages we can surrogate.