Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Add VoodooSMBus Maybe? #2

Closed
khokho opened this issue Jun 5, 2020 · 20 comments
Closed

Add VoodooSMBus Maybe? #2

khokho opened this issue Jun 5, 2020 · 20 comments
Labels
enhancement New feature or request

Comments

@khokho
Copy link

khokho commented Jun 5, 2020

Hello,
I'm super new to hackintosh but I somehow managed to boot it up on my t480. I found you repo a bit too late but it's really a blessing. 💯 👍
I found this kext: https://github.com/VoodooSMBus/VoodooSMBus which I tried to install but could figure out the .patch files and messed up the boot. So I'm just suggesting you to maybe try it.

@khokho
Copy link
Author

khokho commented Jun 5, 2020

The problem with current setup is when I have one finger in the middle of touchpad and I touch another one on left bottom corner, while releasing the on in the middle, the cursor jumps around. And it really drives on my nerves 😄
And I hope I'll be fixed in VoodooSMBus

@EETagent
Copy link
Owner

EETagent commented Jun 8, 2020

@khokho Thanks, it looks really interesting.

00:1f.4 SMBus [0c05]: Intel Corporation Sunrise Point-LP SMBus [8086:9d23] (rev 21)

T480 should be supported as its shares same SMBus with supported T480s.
I will look at it tomorrow or the day after tomorrow. PM981 is still giant mess and really unstable. I moved my ThinkPad to Fedora temporary because of that. As soon as I get Catalina on external drive again ( There are problems with sleep when running from USB drive. Does sleep work for you? ) and edit readme.

@khokho
Copy link
Author

khokho commented Jun 8, 2020

Thank you. I have 8086:9d23 as well.

Sleep works fine for me but I'm running on internal drive. So I can't help you with that one.

Only other problem I have is headphone jack start sounding weird at random times.
I found this repo which mentions jack issues which I'm gonna try out.
https://github.com/tienhuynh5312/ThinkPad-T480-Hackintosh

@khokho
Copy link
Author

khokho commented Jun 9, 2020

^ jack audio got fixed with above repo. But instead of running his provided "read and write.app", I executed:
sudo mount -uw /
then ./install.sh and reboot.

@EETagent
Copy link
Owner

EETagent commented Jun 9, 2020

@khokho When you tried installing that kext, did you compiled the latest version? Support for OpenCore has been recently added. Last official release is from October 2019, that's a long time.

VoodooSMBus.kext.zip

@khokho
Copy link
Author

khokho commented Jun 9, 2020

Oh, I see. Didn't notice that...
I'll try again when I have free time

khokho added a commit to khokho/T480-OpenCore-Hackintosh that referenced this issue Jun 9, 2020
@khokho khokho mentioned this issue Jun 9, 2020
@EETagent EETagent added the enhancement New feature or request label Jun 9, 2020
@khokho
Copy link
Author

khokho commented Jun 11, 2020

52a310a fixed my jumpy trackpad. All the gestures also seem to be much better! I also turned on the Tap to drag in accessibility and it's working like a charm.

@EETagent
Copy link
Owner

It is absolutely awesome. I am not going to merge it now to the master though as there are still issues with TrackPoint ( New version could fix that ) and longer boot times ( What for you? )

@khokho
Copy link
Author

khokho commented Jun 11, 2020

I feel like trackpoint is also better now but I don't use it so I might be wrong.
And for boot time it feels the same. Booting from zero takes 17 seconds til opencore(which is a lot compared to linux bootloaders) and 37 seconds to login screen. But I think It was kind of same without VoodooSMBus. I'll test it soon.

@EETagent
Copy link
Owner

EETagent commented Jun 11, 2020

17 seconds until OC boot screen are really long. 8-6 seconds are more normal

For me, macOS sometimes boot really fast from OC boot menu, sometimes quite long.

@danny7g
Copy link

danny7g commented Jun 12, 2020

I opened an issue to discuss this and closed - sorry I missed this originally.

I separately tested VoodooRMI and, yes, it's great. There are a few timeout errors in the Verbose Bootlog causing extended boot time. I think it relates to the trackpad instructions in SSDT-KBRD-TP.aml in the ACPI folder.

I've just tested this out within the last 30 minutes, so hopefully I'll be able to chase down the exact issue this weekend.

@EETagent
Copy link
Owner

EETagent commented Jun 13, 2020

Every TrackPad and TrackPoint settings was removed from SSDT-KBRD-TP ( Now only KBRD ). I removed also SSDT-SBUS as it can cause conflicts with VoodooSMBus

Latest versions in testing branch or release tab

@khokho
Copy link
Author

khokho commented Jun 13, 2020

I don't think it's your issue but DisableWhileTrackpoint=NO does not allow touchpad with trackpoint. On the other hand it does work with trackpoint buttons(with YES touchpad was disabled everytime I pressed them). All my personal problems are solved but DisableWhileTrackpoint=NO does not work and neither does DisableWhileTyping=NO.

@khokho
Copy link
Author

khokho commented Jun 13, 2020

Also I just fixed my slow boot time to opencore with disabling CMS support.

@danny7g
Copy link

danny7g commented Jun 16, 2020

just posted this in the VoodoSMBus issues, too, but though i'd bring it here directly.

i took a shot at recreating the the plist patches in opencore. opencore doesn't actually allow plist patching, but just blocks the kexts from loading. the patches go in the root -> kernel -> block section. the plist is very rough outside of this section, so i wouldn't use it for anything else.

config.plist.zip
Screen Shot 2020-06-15 at 9 49 28 PM

@EETagent
Copy link
Owner

EETagent commented Jun 16, 2020

@danny7g Thanks, I will add those patches to the plist file.

@danny7g
Copy link

danny7g commented Jun 17, 2020

updated voodoosmbus from release version 2.0
-removed Elan Trackpad support - gets rid of timeout on boot
-removes other smbus pci id listed (assuming we have the same pci id)

i also ended up just deleting those kexts blocked in the post above.

trackpad.zip

@EETagent
Copy link
Owner

@danny7g @khokho

Are there any other issues? I am going to squash merge it soon.

@khokho
Copy link
Author

khokho commented Jun 17, 2020

Nope. Merge it

@EETagent
Copy link
Owner

Because VoodooSMBus and VoodooRMI are already in master, I am closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants