Skip to content

{2023.06}[2023a,sapphire_rapids] PyTorch 2.1.2 #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 4 commits into from
Jan 24, 2025
Merged

{2023.06}[2023a,sapphire_rapids] PyTorch 2.1.2 #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33f4321
add PyTorch
bedroge Jan 23, 2025
da98c52
increase max_failed_tests for PyTorch 2.1.2 to 4 for Sapphire Rapids
bedroge Jan 23, 2025
a2fc9e7
add PyTorch 2.1.2 issue (too many failing tests) for Sapphire Rapids
bedroge Jan 24, 2025
ef55a02
Merge branch '2023.06-software.eessi.io' into sapphire_rapids_pytorch…
bedroge Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions easystacks/software.eessi.io/2023.06/sapphire_rapids/eessi-2023.06-eb-4.9.0-2023a.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,7 @@ easyconfigs:
options:
from-pr: 19471
include-easyblocks-from-pr: 3036
- PyTorch-2.1.2-foss-2023a.eb:
options:
# see https://github.com/easybuilders/easybuild-easyconfigs/pull/19573
from-pr: 19573
14 changes: 10 additions & 4 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'
CPU_TARGET_A64FX = 'aarch64/a64fx'

CPU_TARGET_SAPPHIRE_RAPIDS = 'x86_64/intel/sapphire_rapids'
CPU_TARGET_ZEN4 = 'x86_64/amd/zen4'

EESSI_RPATH_OVERRIDE_ATTR = 'orig_rpath_override_dirs'
Expand Down Expand Up @@ -817,11 +818,16 @@ def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs):

def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
"""
Pre-test hook for PyTorch: increase max failing tests for ARM for PyTorch 2.1.2
See https://github.com/EESSI/software-layer/pull/444#issuecomment-1890416171
Pre-test hook for PyTorch: increase max failing tests for ARM and Intel Sapphire Rapids for PyTorch 2.1.2
See https://github.com/EESSI/software-layer/pull/444#issuecomment-1890416171 and
https://github.com/EESSI/software-layer/pull/875#issuecomment-2606854400
"""
if self.name == 'PyTorch' and self.version == '2.1.2' and get_cpu_architecture() == AARCH64:
self.cfg['max_failed_tests'] = 10
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if self.name == 'PyTorch' and self.version == '2.1.2':
if get_cpu_architecture() == AARCH64:
self.cfg['max_failed_tests'] = 10
if cpu_target == CPU_TARGET_SAPPHIRE_RAPIDS:
self.cfg['max_failed_tests'] = 4


def pre_single_extension_hook(ext, *args, **kwargs):
Expand Down
4 changes: 4 additions & 0 deletions eessi-2023.06-known-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,7 @@
- SciPy-bundle-2023.11-gfbf-2023b:
- issue: https://github.com/EESSI/software-layer/issues/318
- info: "2 failing tests (vs 54876 passed) in scipy test suite"
- x86_64/intel/sapphire_rapids:
- PyTorch-2.1.2-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "4 failing tests (out of 209567) on x86_64/intel/sapphire_rapids"