Adding general way to handle filtered deps when installing software#1095
Closed
Crivella wants to merge 2 commits intoEESSI:2023.06-software.eessi.iofrom
Closed
Adding general way to handle filtered deps when installing software#1095Crivella wants to merge 2 commits intoEESSI:2023.06-software.eessi.iofrom
Crivella wants to merge 2 commits intoEESSI:2023.06-software.eessi.iofrom
Conversation
Contributor
Author
|
Beside the new LLVM hook #1093 this behavior seems to be present only in the The structure of the
VS
This would probably require having a way to deal with different folder structure in the EBlocks and setting the variables in a dedicated way for every filtered deps EG since |
Contributor
|
This is a pretty big hammer, I would rather see us handle this case by case, as is being done in #1093 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now every time a software that relies on calling
get_software_rootfor a filtered deps is called requires and ad-hoc fix via an hook.This is a proposed way to automatically point the respective
$EBROOT...variable to the compat layer for every filtered deps.TODO / Ideas
filter_depsas in frameworkpre_configure?