Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LL/CON/MAS/BV-74-C: no verification if parameters are set correctly #7

Open
kruithofa opened this issue Jan 24, 2020 · 2 comments
Open

LL/CON/MAS/BV-74-C: no verification if parameters are set correctly #7

kruithofa opened this issue Jan 24, 2020 · 2 comments

Comments

@kruithofa
Copy link
Collaborator

The DLE control procedure is called with different length & timing parameters.
An event is generated by the HCI returning the actual length & timing settings used.

The test needs to verify that the returned values are correct
@aescolar
Copy link
Collaborator

Note: This causes the test to pass in EDTT but it is failing in EBQ

@kruithofa
Copy link
Collaborator Author

There is some verification of parameters in the routine that receives the event-results, but this is very generic, and probably not strict enough; some further investigation is required

wopu-ot pushed a commit to wopu-ot/EDTT that referenced this issue Oct 1, 2021
@rymanluk @wopu-ot
btsnoop: Add support for btsnoop
157bfc0 
With this patch, when "--store_btsnoop=true", the HCI logs
are stored in the btsnoop_[timestamp].log
which can be read by e.g. btmon -r

By defult it is false;

When "--btmon_socket_path=socket_path" is provided, edttool will try to
connect to unix socket opened by "btmon -s socket_path"

By default edttool tries to connect /tmp/btmon-sock

UpperTester is a [hci10] and LowerTester is a [hci11]
This helps to verify HCI communication

= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,UpperTester)          [hci10] 0.551917
= Open Index: 00:00:00:00:00:00                                      [hci10] 0.551933
= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,LowerTester)          [hci11] 0.551943
= Open Index: 00:00:00:00:00:00                                      [hci11] 0.551947
= Testing session started:                                           [hci10] 0.552393
= IAL/CIS/UNF/PER/BV-01-C:                                           [hci10] 0.563156
< HCI Command: Reset (0x03|0x0003) plen 0                         EDTTool#1 [hci10] 0.563523
> HCI Event: Command Complete (0x0e) plen 4                       EDTTool#2 [hci10] 0.563886
      Reset (0x03|0x0003) ncmd 1
        Status: Success (0x00)
< HCI Command: Read Local Supported Features (0x04|0x0003) plen 0 EDTTool#3 [hci10] 0.563939
> HCI Event: Command Complete (0x0e) plen 12                      EDTTool#4 [hci10] 0.564344
      Read Local Supported Features (0x04|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0x00 0x00 0x00 0x00 0x60 0x00 0x00 0x00
          BR/EDR Not Supported
          LE Supported (Controller)
< HCI Command: LE Read Local Supported Features (0x08|0x0003) plen 0   EDTTool#5 [hci10] 0.564382
> HCI Event: Command Complete (0x0e) plen 12                           EDTTool#6 [hci10] 0.564989
      LE Read Local Supported Features (0x08|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0xff 0x7f 0x01 0x7f 0x0e 0x00 0x00 0x00
          LE Encryption
          Connection Parameter Request Procedure
          Extended Reject Indication
          Slave-initiated Features Exchange
          LE Ping
          LE Data Packet Length Extension
          LL Privacy
          Extended Scanner Filter Policies
          LE 2M PHY
          Stable Modulation Index - Transmitter
          Stable Modulation Index - Receiver
          LE Coded PHY
          LE Extended Advertising
          LE Periodic Advertising
          Channel Selection Algorithm EDTTool#2
          Minimum Number of Used Channels Procedure
          Periodic Advertising Sync Transfer - Sender
          Periodic Advertising Sync Transfer - Recipient
          Sleep Clock Accuracy Updates
          Remote Public Key Validation
          Connected Isochronous Stream - Master
          Connected Isochronous Stream - Slave
          Isochronous Broadcaster
          LE Power Control Request
          LE Power Change Indication
          LE Path Lost Monitoring
< HCI Command: Set Event Mask (0x03|0x0001) plen 8               EDTTool#7 [hci10] 0.565037
        Mask: 0x20001fffffffffff
          Inquiry Complete
          Inquiry Result
          Connection Complete
          Connection Request
          Disconnection Complete
          Authentication Complete
          Remote Name Request Complete
          Encryption Change
          Change Connection Link Key Complete
          Master Link Key Complete
          Read Remote Supported Features Complete
          Read Remote Version Information Complete
          QoS Setup Complete
          Command Complete
          Command Status
          Hardware Error
          Flush Occurred
          Role Change
          Number of Completed Packets
          Mode Change
          Return Link Keys
          PIN Code Request
          Link Key Request
          Link Key Notification
          Loopback Command
wopu-ot pushed a commit that referenced this issue Oct 6, 2021
@rymanluk @wopu-ot
btsnoop: Add support for btsnoop
2499586 
With this patch, when "--store_btsnoop=true", the HCI logs
are stored in the btsnoop_[timestamp].log
which can be read by e.g. btmon -r

By defult it is false;

When "--btmon_socket_path=socket_path" is provided, edttool will try to
connect to unix socket opened by "btmon -s socket_path"

By default edttool tries to connect /tmp/btmon-sock

UpperTester is a [hci10] and LowerTester is a [hci11]
This helps to verify HCI communication

= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,UpperTester)          [hci10] 0.551917
= Open Index: 00:00:00:00:00:00                                      [hci10] 0.551933
= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,LowerTester)          [hci11] 0.551943
= Open Index: 00:00:00:00:00:00                                      [hci11] 0.551947
= Testing session started:                                           [hci10] 0.552393
= IAL/CIS/UNF/PER/BV-01-C:                                           [hci10] 0.563156
< HCI Command: Reset (0x03|0x0003) plen 0                         #1 [hci10] 0.563523
> HCI Event: Command Complete (0x0e) plen 4                       #2 [hci10] 0.563886
      Reset (0x03|0x0003) ncmd 1
        Status: Success (0x00)
< HCI Command: Read Local Supported Features (0x04|0x0003) plen 0 #3 [hci10] 0.563939
> HCI Event: Command Complete (0x0e) plen 12                      #4 [hci10] 0.564344
      Read Local Supported Features (0x04|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0x00 0x00 0x00 0x00 0x60 0x00 0x00 0x00
          BR/EDR Not Supported
          LE Supported (Controller)
< HCI Command: LE Read Local Supported Features (0x08|0x0003) plen 0   #5 [hci10] 0.564382
> HCI Event: Command Complete (0x0e) plen 12                           #6 [hci10] 0.564989
      LE Read Local Supported Features (0x08|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0xff 0x7f 0x01 0x7f 0x0e 0x00 0x00 0x00
          LE Encryption
          Connection Parameter Request Procedure
          Extended Reject Indication
          Slave-initiated Features Exchange
          LE Ping
          LE Data Packet Length Extension
          LL Privacy
          Extended Scanner Filter Policies
          LE 2M PHY
          Stable Modulation Index - Transmitter
          Stable Modulation Index - Receiver
          LE Coded PHY
          LE Extended Advertising
          LE Periodic Advertising
          Channel Selection Algorithm #2
          Minimum Number of Used Channels Procedure
          Periodic Advertising Sync Transfer - Sender
          Periodic Advertising Sync Transfer - Recipient
          Sleep Clock Accuracy Updates
          Remote Public Key Validation
          Connected Isochronous Stream - Master
          Connected Isochronous Stream - Slave
          Isochronous Broadcaster
          LE Power Control Request
          LE Power Change Indication
          LE Path Lost Monitoring
< HCI Command: Set Event Mask (0x03|0x0001) plen 8               #7 [hci10] 0.565037
        Mask: 0x20001fffffffffff
          Inquiry Complete
          Inquiry Result
          Connection Complete
          Connection Request
          Disconnection Complete
          Authentication Complete
          Remote Name Request Complete
          Encryption Change
          Change Connection Link Key Complete
          Master Link Key Complete
          Read Remote Supported Features Complete
          Read Remote Version Information Complete
          QoS Setup Complete
          Command Complete
          Command Status
          Hardware Error
          Flush Occurred
          Role Change
          Number of Completed Packets
          Mode Change
          Return Link Keys
          PIN Code Request
          Link Key Request
          Link Key Notification
          Loopback Command
kruithofa pushed a commit to kruithofa/EDTT that referenced this issue Oct 6, 2021
@rymanluk @kruithofa
btsnoop: Add support for btsnoop
1ed0057 
With this patch, when "--store_btsnoop=true", the HCI logs
are stored in the btsnoop_[timestamp].log
which can be read by e.g. btmon -r

By defult it is false;

When "--btmon_socket_path=socket_path" is provided, edttool will try to
connect to unix socket opened by "btmon -s socket_path"

By default edttool tries to connect /tmp/btmon-sock

UpperTester is a [hci10] and LowerTester is a [hci11]
This helps to verify HCI communication

= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,UpperTester)          [hci10] 0.551917
= Open Index: 00:00:00:00:00:00                                      [hci10] 0.551933
= New Index: 00:00:00:00:00:00 (Primary,VIRTIO,LowerTester)          [hci11] 0.551943
= Open Index: 00:00:00:00:00:00                                      [hci11] 0.551947
= Testing session started:                                           [hci10] 0.552393
= IAL/CIS/UNF/PER/BV-01-C:                                           [hci10] 0.563156
< HCI Command: Reset (0x03|0x0003) plen 0                         EDTTool#1 [hci10] 0.563523
> HCI Event: Command Complete (0x0e) plen 4                       EDTTool#2 [hci10] 0.563886
      Reset (0x03|0x0003) ncmd 1
        Status: Success (0x00)
< HCI Command: Read Local Supported Features (0x04|0x0003) plen 0 EDTTool#3 [hci10] 0.563939
> HCI Event: Command Complete (0x0e) plen 12                      EDTTool#4 [hci10] 0.564344
      Read Local Supported Features (0x04|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0x00 0x00 0x00 0x00 0x60 0x00 0x00 0x00
          BR/EDR Not Supported
          LE Supported (Controller)
< HCI Command: LE Read Local Supported Features (0x08|0x0003) plen 0   EDTTool#5 [hci10] 0.564382
> HCI Event: Command Complete (0x0e) plen 12                           EDTTool#6 [hci10] 0.564989
      LE Read Local Supported Features (0x08|0x0003) ncmd 1
        Status: Success (0x00)
        Features: 0xff 0x7f 0x01 0x7f 0x0e 0x00 0x00 0x00
          LE Encryption
          Connection Parameter Request Procedure
          Extended Reject Indication
          Slave-initiated Features Exchange
          LE Ping
          LE Data Packet Length Extension
          LL Privacy
          Extended Scanner Filter Policies
          LE 2M PHY
          Stable Modulation Index - Transmitter
          Stable Modulation Index - Receiver
          LE Coded PHY
          LE Extended Advertising
          LE Periodic Advertising
          Channel Selection Algorithm EDTTool#2
          Minimum Number of Used Channels Procedure
          Periodic Advertising Sync Transfer - Sender
          Periodic Advertising Sync Transfer - Recipient
          Sleep Clock Accuracy Updates
          Remote Public Key Validation
          Connected Isochronous Stream - Master
          Connected Isochronous Stream - Slave
          Isochronous Broadcaster
          LE Power Control Request
          LE Power Change Indication
          LE Path Lost Monitoring
< HCI Command: Set Event Mask (0x03|0x0001) plen 8               EDTTool#7 [hci10] 0.565037
        Mask: 0x20001fffffffffff
          Inquiry Complete
          Inquiry Result
          Connection Complete
          Connection Request
          Disconnection Complete
          Authentication Complete
          Remote Name Request Complete
          Encryption Change
          Change Connection Link Key Complete
          Master Link Key Complete
          Read Remote Supported Features Complete
          Read Remote Version Information Complete
          QoS Setup Complete
          Command Complete
          Command Status
          Hardware Error
          Flush Occurred
          Role Change
          Number of Completed Packets
          Mode Change
          Return Link Keys
          PIN Code Request
          Link Key Request
          Link Key Notification
          Loopback Command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aescolar @kruithofa