-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finite difference example #635
base: master
Are you sure you want to change the base?
Conversation
@colemanjs FYI |
1877c5d
to
c2ea6ea
Compare
k - planes[b][2], 0 ); | ||
} ); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to add comment about the problem. I think this is about unsteady heat equation problem in 3d.
The governing equstion :
Neumann boundary condition (describing heat flux ) :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwitaechong, you are correct. This boundary conditions is just an adiabatic one. I will correct the description.
Also, it is worth pointing out that I think the left-hand and right-hand sides are swapped...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colemanjs can you add a more detailed comment below?
****************************************************************************/ | ||
|
||
#include <array> | ||
#include <math.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <math.h> | |
#include <cmath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
MPI_Init( &argc, &argv ); | ||
{ | ||
Kokkos::ScopeGuard scope_guard( argc, argv ); | ||
|
||
finiteDifference(); | ||
} | ||
MPI_Finalize(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MPI_Init( &argc, &argv ); | |
{ | |
Kokkos::ScopeGuard scope_guard( argc, argv ); | |
finiteDifference(); | |
} | |
MPI_Finalize(); | |
MPI_Init( &argc, &argv ); | |
Kokkos::initialize( argc, argv ); | |
finiteDifference(); | |
Kokkos::finalize(); | |
MPI_Finalize(); |
is more readable IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Co-authored-by: John Coleman <[email protected]>
c2ea6ea
to
a70fd5a
Compare
Add new example. Use a new directory to differentiate between the tutorial for individual components
TODO: add a link in the wiki somewhere (proxy app page?)