Change distribution default parameters to Twiss in dashboard #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proy30
added
component: dashboard
|
As far as the |
cemitch99
reviewed
Oct 24, 2024
Twiss is now default, 'Native' changed to 'Quadratic Form' and placed as secondary option
Helper function moved to distributionFuntions.py, and simplified code structure. no functionality change
…ameters Thermal is set to have a single set of parameters - 'k', 'kT', 'kT_halo', 'normali ze', 'normalize_halo', halo'
proy30
force-pushed
the
dashboard/change_to_twiss_default_for_distribution
branch
from
6e687d0
to
7d8151f
Compare
|
Updated with units |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the primary option for beam distribution configurations to "Twiss". The previously primary set, "Native," has been renamed to "Quadratic Form" and is now available as an alternative parameterization for users.
In addition, this PR makes minor adjustments to the code structure and docstrings within the beam distribution section. These changes do not affect functionality.
Tested with this example to ensure correct functionality.
Checklist
I noticed that all beta/emitt parameters must have non-zero values, but this validation is missing in the current PR. PR #690 includes a modified helper function with built-in validation capabilities for non-zero values. Better to either include beta/emitt validation in that PR or in a new one once #690 is merged.
Resolves #724