-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeamMonitor: Enable Filtering by Cycle (Turn) #713
Merged
cemitch99
merged 8 commits into
ECP-WarpX:development
from
ax3l:topic-cycle-interval-filter
Oct 9, 2024
Merged
BeamMonitor: Enable Filtering by Cycle (Turn) #713
cemitch99
merged 8 commits into
ECP-WarpX:development
from
ax3l:topic-cycle-interval-filter
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-cycle-interval-filter
branch
3 times, most recently
from
September 24, 2024 19:22
13f11e1
to
1f61fad
Compare
ax3l
changed the title
Topic cycle interval filter
BeamMonitor: Enable Filtering by Turn
Sep 24, 2024
ax3l
changed the title
BeamMonitor: Enable Filtering by Turn
BeamMonitor: Enable Filtering by Cycle (Turn)
Sep 24, 2024
ax3l
force-pushed
the
topic-cycle-interval-filter
branch
from
September 25, 2024 02:22
1f61fad
to
5eaa4c8
Compare
cemitch99
reviewed
Sep 25, 2024
cemitch99
reviewed
Sep 25, 2024
cemitch99
reviewed
Sep 25, 2024
cemitch99
reviewed
Sep 25, 2024
ax3l
force-pushed
the
topic-cycle-interval-filter
branch
from
September 26, 2024 21:59
0470fc7
to
6d26269
Compare
For cycle argument
Co-authored-by: Chad Mitchell <[email protected]>
ax3l
force-pushed
the
topic-cycle-interval-filter
branch
from
October 4, 2024 00:09
6d26269
to
987fd3d
Compare
@cemitch99 this is ready for review & merge now :) |
cemitch99
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. This is a useful feature to have, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For modeling of periodic lattices, we can now sub-select the output of particles at the
BeamMonitor
/beam_monitor
element to every N-th period (turn or cycle).This is first, simple (equidistant) implementation of #662.
To Do