Add beam eigenemittances to reduced diagnostics. #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Clean Doxygen and delete unused function TestMult (used for benchmarking).
Clean Doxygen
Clean Doxygen
Remove duplicate Doxygen comments in EmittanceInvariants.cpp/h
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
cemitch99
commented
Sep 13, 2024
cemitch99
commented
Sep 13, 2024
cemitch99
commented
Sep 13, 2024
cemitch99
commented
Sep 13, 2024
Comment benchmarking call to Eigenemittance to avoid unused variable errors.
|
This works, but suffers a loss of precision in certain cases (eg, uncoupled beams with et << ex = ey) due to the appearance of a small discriminant in Cardano's formula. A fix for this is under investigation. Some tests failing for unrelated reasons due to pytest. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Corrected path to benchmark test files.
Update path for analysis scripts.
ax3l
reviewed
Sep 25, 2024
Co-authored-by: Axel Huebl <[email protected]>
Add PROFILE header.
Use math functions from std:: (sqrt, pow, sin, cos, etc) -> (std::sqrt, std::pow, std::sin, std::cos, etc).
Co-authored-by: Axel Huebl <[email protected]>
Remove std::math for complex functions.
cemitch99
commented
Sep 26, 2024
cemitch99
commented
Sep 26, 2024
Only spaces
ax3l
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Oct 3, 2024
Add amrex::SmallMatrix class with compile time size. Useful for, e.g.: - ECP-WarpX/impactx#714 - ECP-WarpX/impactx#702
cemitch99
commented
Oct 5, 2024
Update treatment of warnings.
Changes to test_transformation.py were not intentional. These were reversed per code review. Co-authored-by: Axel Huebl <[email protected]>
ax3l
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds calculation of the 3 eigenemittances (or mode emittances) of the 6D beam distribution from particle data as an additional reduced diagnostic. Addresses Issue #663.