Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape code in BeamMonitor when openPMD is off #631

Merged

Conversation

n01r
Copy link
Member

@n01r n01r commented Jun 5, 2024

This fixes an issue where the code could not be compiled with the following combination of build options.

cmake -S . -B build -DImpactX_MPI=OFF -DImpactX_PYTHON=ON -DImpactX_COMPUTE=NOACC -DImpactX_OPENPMD=OFF

This was first encountered by @proy30. Thanks for finding this!

This fixes an issue where the code could not be compiled.
@n01r n01r requested review from ax3l and proy30 June 5, 2024 22:07
@n01r n01r added backend: openmp Specific to OpenMP execution (CPUs) install labels Jun 5, 2024
@ax3l ax3l self-assigned this Jun 10, 2024
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: diagnostics all types of outputs and removed backend: openmp Specific to OpenMP execution (CPUs) labels Jun 10, 2024
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l ax3l merged commit b5506c2 into ECP-WarpX:development Jun 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: diagnostics all types of outputs install
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants