Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add Custom Elements #624

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Doc: Add Custom Elements #624

merged 2 commits into from
Jun 14, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 24, 2024

Document how to add custom beamline elements to ImpactX as a user workflow.

@ax3l ax3l added the component: documentation Docs, readme and manual label May 24, 2024
@ax3l ax3l changed the title Doc: Programmable Element (FODO) Doc: Add Custom Elements May 28, 2024
@ax3l ax3l marked this pull request as ready for review June 11, 2024 20:31
@ax3l ax3l requested a review from cemitch99 June 11, 2024 20:37
@ax3l ax3l force-pushed the doc-add-element branch 8 times, most recently from 212efaf to 617937d Compare June 11, 2024 21:12
Document how to add custom beamline elements to ImpactX as a user
workflow.
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I made one small comment.

@ax3l ax3l mentioned this pull request Jun 14, 2024
2 tasks
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ax3l ax3l enabled auto-merge (squash) June 14, 2024 22:00
@ax3l ax3l merged commit 48204c9 into ECP-WarpX:development Jun 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Docs, readme and manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants