Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize with value all aux, cax fields #5049

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Initialize with value all aux, cax fields #5049

merged 1 commit into from
Jul 15, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Jul 15, 2024

The fact that these aux and cax fields were not initialized (to zero, like other similar fields), seems to be the cause of errors that show up in #4922 for two CI tests, scraping and scraping_filter.

@EZoni EZoni added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Jul 15, 2024
@EZoni EZoni mentioned this pull request Jul 15, 2024
Merged
3 tasks
@EZoni EZoni requested review from dpgrote and RemiLehe July 15, 2024 20:41
dpgrote
dpgrote approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would say that this is a good thing to do anyway.

@ax3l ax3l merged commit b6cf99d into ECP-WarpX:development Jul 15, 2024
45 checks passed
@ax3l ax3l self-assigned this Jul 15, 2024
@ax3l ax3l added the component: boundary PML, embedded boundaries, et al. label Jul 15, 2024
@EZoni EZoni deleted the EZoni_init_cax_fields branch July 15, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgrote dpgrote dpgrote approved these changes

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

Assignees

@ax3l ax3l

Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: boundary PML, embedded boundaries, et al.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EZoni @dpgrote @ax3l