Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data layer and tests for tags and user interested events. #63

Merged
merged 13 commits into from
Nov 6, 2023

Conversation

jioh-kim
Copy link
Contributor

@jioh-kim jioh-kim commented Nov 6, 2023

Closes: #33
This PR contains the new TagDataLayer and UserInterestedDataLayer classes, which can now be used to access the database. There are also tests to ensure they work as expected and to provide examples on how to use the new classes and methods.

@PaulaPerdomo
Copy link
Contributor

PaulaPerdomo commented Nov 6, 2023

For this PR please go to backend/tests and run pytest for all the different database tests, if everything goes well there should be 27 tests passing :)

Copy link
Contributor

@divyaK15 divyaK15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All 31 tests pass. Skimmed the updated files.

@jioh-kim
Copy link
Contributor Author

jioh-kim commented Nov 6, 2023

@divyaK15 Could you pull again? should have 27 tests now

@jioh-kim jioh-kim merged commit 2c3a533 into main Nov 6, 2023
@PaulaPerdomo PaulaPerdomo added infrastructure For the initial setup backend For backend development tasks labels Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added this to the Milestone 4.5 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend For backend development tasks infrastructure For the initial setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra][Backend] Design Relevant Classes using SOLID Principles
4 participants