Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Details page #62

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Post Details page #62

merged 8 commits into from
Nov 6, 2023

Conversation

karishma-shah
Copy link
Contributor

@karishma-shah karishma-shah commented Nov 6, 2023

Closes #79

This PR creates the PostDetails page which is the page that contains an expanded view/details about every post. Currently, the Edit button in the top right corner will appear for every post since Auth is not configured yet, but it should only ideally appear for the person who has created it.

Currently, it is using mockData to render the post contents - however, in the next PR, they will be fetched from the database via an API call.

Here is a visual:

Screen.Recording.2023-11-05.at.7.46.14.PM.mov

To test the changes:

  1. checkout this branch
  2. run npm start
  3. in another terminal, run npm run start-backend

Copy link
Contributor

@divyaK15 divyaK15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the /post/:postid URL and this is what shows up. Is there another path I should be using?
Screenshot 2023-11-05 at 8 23 42 PM

@karishma-shah
Copy link
Contributor Author

karishma-shah commented Nov 6, 2023

I ran the /post/:postid URL and this is what shows up. Is there another path I should be using? Screenshot 2023-11-05 at 8 23 42 PM

Only the first post is configured to work. So you have to click that one to test. Sorry forgot to add that in the PR description. Also you dont directly run the /post/:postid, you click the first post on the landing page and it will lead you to it. The :postId should be a number.

Copy link
Contributor

@divyaK15 divyaK15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested out all the functionalities shown in the video and they worked. Resizing looks good. I was able to search an event I just edited and all the edit fields work.

@karishma-shah karishma-shah merged commit fafa0bd into main Nov 6, 2023
@tmahabir
Copy link
Contributor

tmahabir commented Nov 6, 2023

Looks fantastic! One thing I noticed is that if you change the image, and then click 'Cancel', the new image remains and doesn't go back to the original photo.

I think the solution would be simply adding setImageSrc(postImage); to the handleCancel function.
(But this exact solution will also change when we start using actual database data and not hardcoding the image with the variable postImage)

Great work!!

@PaulaPerdomo PaulaPerdomo changed the title [FE] Post Details page Post Details page Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added the frontend For frontend developments label Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added this to the Milestone 4.5 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend For frontend developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Post details page
4 participants