Search, filter and sort. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to integrate search bar results with it
…mplement sorting with a range, which seems to be a bug on the backend side
|
Your Render PR Server URL is https://bluesurf-pr-107.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cl8rlo76e7vc73c9gmd0. |
|
Your Render PR Server URL is https://bluesurf-fe-fr-pr-107.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cl8rlon6e7vc73c9gmig. |
meriam04
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Overall I'm glad we have this functionality combined into one function. There are a few changes that should be made before deploying though. We shouldn't be populating the mock database because it will override our PosgreSQL one. And the clubs and locations should be returned in alphabetical order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
Closes #3.
Closes #4.
Closes #11.
Closes #13.
Closes #18.
This PR adds the search, filter and sort capability for posts.
Each of the capabilities function both together and individually (i.e., searching can work standalone, or with filtering). If the user inputs a query for searching and then decides to filter by tags, the database query adds the current options to the query to restrict the results more.
Tests for the database function
search_filter_sortwere added under thetest_datalayer_event.pyfile and considers a variety of scenarios, that include formatting as well as a combination of everything you can do.Please check the functionality in the frontend :) and run pytest to ensure the tests pass.