Add rings #11
Merged
Add rings #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing release strategy
Not used by any Slot. FYI: In PTable there is a similar Signal that is used
|
Thanks for the effort :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suddenly had to add_ring branches, which looked identical.
But as I am pulling into your ring branch, it should not matter. I hope.
Changes:
I did not make large changes.
I prefer to use ALI6/ARO6 over benzene ..., this allows to keep a consistent naming convention, when we want to integrate 5 rings or larger rings. IMO
I added deprecation warning
You wanted to have a single API that sets the chemicalType and subtype. And only in the molEditor, have the private attributes ._type and ._subtype. I'd argue that is what is happening, although I am using three different functions to set those. setAtom, setBond and setRing.