WIP net10.0 Update

.github/workflows/dynamo_bin_diff.yml

@@ -27,11 +27,11 @@ jobs:
         uses: microsoft/setup-msbuild@v2
       - name: Install dependencies for windows runtime
         run: |
-          dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net8.0
+          dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net10.0
       - name: Build Dynamo with MSBuild
         run: |
           Write-Output "***Continue with the build, Good luck developer!***"
-          msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release /p:DotNet=net8.0
+          msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release /p:DotNet=net10.0
       - name: Look for DynamoCLI.exe
         run: |
           Write-Output "***Locating DynamoCLI.exe!***"
@@ -67,11 +67,11 @@ jobs:
         uses: microsoft/setup-msbuild@v2
       - name: Install dependencies for windows runtime
         run: |
-          dotnet restore ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net8.0
+          dotnet restore ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net10.0
       - name: Build Dynamo with MSBuild
         run: |
           Write-Output "***Continue with the build, Good luck developer!***"
-          msbuild ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release /p:DotNet=net8.0
+          msbuild ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release /p:DotNet=net10.0
       - name: Look for DynamoCLI.exe
         run: |
           Write-Output "***Locating DynamoCLI.exe!***"

.github/workflows/issue_type_predicter.yml

@@ -83,7 +83,7 @@ jobs:
         if: env.analysis_response == 'Valid'
         run: |
           dotnet build ./IssuesTypePredicter/IssuesTypePredicter.sln --configuration Release
-          cp ./IssuesTypePredicter/IssuesTypePredicterML.ConsoleApp/bin/Release/net8.0/MLModel.zip .
+          cp ./IssuesTypePredicter/IssuesTypePredicterML.ConsoleApp/bin/Release/net10.0/MLModel.zip .
 
       # Execute the IssuesTypePredicter program and pass 'issue_json_string' as a parameter
       - name: Run Issues Type Predicter

src/Config/CS_SDK.props

@@ -6,7 +6,7 @@
     <PlatformTarget >x64</PlatformTarget>
     <!--Use the property DotNet to set TargetFramework from commandline without forcing it on all projects-->
     <!--Ex. DynamoServices uses TargetFramework netstandard2.0 -->
-    <DotNet>net8.0</DotNet>
+    <DotNet>net10.0</DotNet>
       <!--Use LibGVer to tell the CI/CD pipeline what the prefered LIBG version is for testing-->
     <LIBGVer>libg_231_0_0</LIBGVer>
     <VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">16.0</VisualStudioVersion>

src/DynamoCoreWpf/Services/IconServices.cs

@@ -1,13 +1,14 @@
+using Dynamo.Engine;
+using Dynamo.Interfaces;
+using Dynamo.Utilities;
 using System;
 using System.Collections.Generic;
 using System.Drawing;
+using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Resources;
 using System.Windows.Media;
-using Dynamo.Engine;
-using Dynamo.Interfaces;
-using Dynamo.Utilities;
 
 namespace Dynamo.Wpf.Services
 {
@@ -80,8 +81,20 @@ internal ImageSource LoadIconInternal(string iconKey)
             ResourceManager rm = new ResourceManager(assemblyName + imagesSuffix, resourceAssembly);
 
             ImageSource bitmapSource = null;
+            Bitmap source = null;
+
+            try
+            {
+                using (var ms = new MemoryStream(rm.GetObject(iconKey) as byte[]))
+                {
+                    source = new Bitmap(ms);
+                }
+            }
+            catch(Exception e)
+            {
+                //log the error
+            }
 
-            var source = (Bitmap)rm.GetObject(iconKey);
             if (source == null)
             {
                 cachedIcons.Add(iconKey, null);

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

@@ -1504,26 +1504,26 @@ internal bool CanUpdateAllPythonEngine(object param)
         /// <param name="isBinding">Should be set to true, if you require to bind the passed
         /// NodeModel engine value with the menu item, works only when a single node is passed in the list.</param>
         internal void AddPythonEngineToMenuItems(List<PythonNodeBase> pythonNodeModel,
-           MenuItem pythonEngineVersionMenu,
+           System.Windows.Controls.MenuItem pythonEngineVersionMenu,
            RoutedEventHandler updateEngineDelegate,
            string engineName, bool isBinding = false)
         {
             //if all nodes in the selection are set to a specific engine, then that engine will be checked in the list.
             bool hasCommonEngine = pythonNodeModel.All(x => x.EngineName == engineName);
-            var currentItem = pythonEngineVersionMenu.Items.Cast<MenuItem>().FirstOrDefault(x => x.Header as string == engineName);
+            var currentItem = pythonEngineVersionMenu.Items.Cast<System.Windows.Controls.MenuItem>().FirstOrDefault(x => x.Header as string == engineName);
             if (currentItem != null)
             {
                 if (pythonNodeModel.Count == 1) return;
                 currentItem.IsChecked = hasCommonEngine;
                 return;
             }
-            MenuItem pythonEngineItem = null;
+            System.Windows.Controls.MenuItem pythonEngineItem = null;
             //if single node, then checked property is bound to the engine value, as python node context menu is not recreated
             if (pythonNodeModel.Count == 1 && isBinding)
             {
                 var pythonNode = pythonNodeModel.FirstOrDefault(); ;
-                pythonEngineItem = new MenuItem { Header = engineName, IsCheckable = false };
-                pythonEngineItem.SetBinding(MenuItem.IsCheckedProperty, new System.Windows.Data.Binding(nameof(pythonNode.EngineName))
+                pythonEngineItem = new System.Windows.Controls.MenuItem { Header = engineName, IsCheckable = false };
+                pythonEngineItem.SetBinding(System.Windows.Controls.MenuItem.IsCheckedProperty, new System.Windows.Data.Binding(nameof(pythonNode.EngineName))
                 {
                     Source = pythonNode,
                     Converter = new CompareToParameterConverter(),
@@ -1534,7 +1534,7 @@ internal void AddPythonEngineToMenuItems(List<PythonNodeBase> pythonNodeModel,
             {
                 //when updating multiple nodes checked value is not bound to any specific node,
                 //rather takes into account all the selected nodes
-                pythonEngineItem = new MenuItem { Header = engineName, IsCheckable = true };
+                pythonEngineItem = new System.Windows.Controls.MenuItem { Header = engineName, IsCheckable = true };
                 pythonEngineItem.IsChecked = hasCommonEngine;
             }
             pythonEngineItem.Click += updateEngineDelegate;