Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add derived types for priority and cache, export them #676

Closed
wants to merge 2 commits into from
Closed

fix(types): add derived types for priority and cache, export them #676

wants to merge 2 commits into from

Conversation

krisztiaan-uic
Copy link

@krisztiaan-uic krisztiaan-uic commented Apr 29, 2020 •
edited
Loading

Make types for Cache and Priority derived types from the corresponding const.
Export these as well, to simplify wrappers and further typing, thanks @vieiralucas

@krisztiaan-uic krisztiaan-uic changed the title fix(types): add derived types for priority and cash fix(types): add derived types for priority and cache Apr 30, 2020
@krisztiaan-uic krisztiaan-uic mentioned this pull request May 1, 2020
Closed
@vieiralucas
Copy link
Contributor

@krisztiaan-uic Can you export these types too? So we can close #678 with your PR

@krisztiaan-uic krisztiaan-uic changed the title fix(types): add derived types for priority and cache fix(types): add derived types for priority and cache, export them May 14, 2020
@krisztiaan-uic
Copy link
Author

included in #654

@krisztiaan-uic krisztiaan-uic deleted the patch-1 branch May 19, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisztiaan-uic @vieiralucas