Skip to content

[Snyk] Fix for 2 vulnerabilities#12

Open
Dustin4444 wants to merge 1 commit intomasterfrom
snyk-fix-a71aefb7c76fb13925b392aece27dfc1
Open

[Snyk] Fix for 2 vulnerabilities#12
Dustin4444 wants to merge 1 commit intomasterfrom
snyk-fix-a71aefb7c76fb13925b392aece27dfc1

Conversation

@Dustin4444
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Prototype Pollution
SNYK-JS-AXIOS-15252993
  828  
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  803  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's security by updating key development dependencies to mitigate two high-severity vulnerabilities. The changes specifically target and resolve known security risks associated with older package versions, ensuring a more robust and secure development environment.

Highlights

  • Vulnerability Fixes: This pull request addresses two high-severity vulnerabilities: Prototype Pollution (SNYK-JS-AXIOS-15252993) and Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295).
  • Dependency Upgrades: The eslint dependency has been upgraded from version 8.56.0 to 10.0.0, and lerna has been upgraded from 6.4.1 to 6.5.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Upgraded eslint from version 8.56.0 to 10.0.0.
    • Upgraded lerna from version 6.4.1 to 6.5.0.
Activity
  • This pull request was automatically generated by Snyk to fix identified vulnerabilities.
  • A warning was noted that the yarn.lock file failed to update and requires manual intervention.
  • Guidance was provided for users utilizing Yarn's zero-installs feature, advising them to run yarn to update the .yarn/cache/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snyk-fix-a71aefb7c76fb13925b392aece27dfc1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Network access: npm eslint in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Dynamic code execution: npm eslint

Eval Type: eval

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is dynamic code execution?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Avoid packages that use dynamic code execution like eval(), since this could potentially execute any code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Dynamic code execution: npm eslint

Eval Type: execScript

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is dynamic code execution?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Avoid packages that use dynamic code execution like eval(), since this could potentially execute any code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Dynamic code execution: npm eslint

Eval Type: Function

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is dynamic code execution?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Avoid packages that use dynamic code execution like eval(), since this could potentially execute any code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Embedded URLs or IPs: npm eslint

URLs: http://www.graphviz.org, http://www.webgraphviz.com, context.report, https://eslint.org/blog/2023/10/deprecating-formatting-rules/, https://eslint.style/guide/migration, https://eslint.style, https://eslint.style/rules/array-bracket-spacing, https://eslint.org/docs/latest/rules/array-bracket-spacing, https://eslint.org/docs/latest/extend/custom-rules#options-schemas, https://eslint.org/docs/latest/integrate/nodejs-api#customizing-ruletester, https://github.com/nodejs/node/blob/master/doc/api/process.md#processstdin, https://github.com/nodejs/node/blob/master/doc/api/process.md#a-note-on-process-io, https://lists.gnu.org/archive/html/bug-gnu-emacs/2016-01/msg00419.html, https://github.com/nodejs/node/issues/7439, https://eslint.style/rules/array-bracket-newline, https://eslint.org/docs/latest/rules/array-bracket-newline, https://eslint.org/docs/latest/rules/class-methods-use-this, https://eslint.org/docs/latest/rules/eqeqeq, https://eslint.style/rules/arrow-spacing, https://eslint.org/docs/latest/rules/arrow-spacing, https://eslint.style/rules/array-element-newline, https://eslint.org/docs/latest/rules/array-element-newline, https://eslint.org/docs/latest/rules/constructor-super, https://eslint.org/docs/latest/rules/block-scoped-var, https://eslint.style/rules/comma-dangle, https://eslint.org/docs/latest/rules/comma-dangle, https://eslint.style/rules/arrow-parens, https://eslint.org/docs/latest/rules/arrow-parens, https://eslint.org/docs/latest/rules/capitalized-comments, https://eslint.org/docs/latest/rules/camelcase, Identifier.property, https://eslint.org/docs/latest/rules/array-callback-return, https://eslint.org/docs/latest/rules/default-case, https://eslint.org/docs/latest/rules/guard-for-in, https://eslint.org/docs/latest/use/migrating-to-7.0.0#deprecate-node-rules, https://github.com/eslint-community/eslint-plugin-n, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/callback-return.md, https://eslint.org/docs/latest/rules/callback-return, https://eslint.org/docs/latest/rules/dot-notation, https://eslint.style/rules/comma-spacing, https://eslint.org/docs/latest/rules/comma-spacing, https://eslint.org/docs/latest/rules/accessor-pairs, https://eslint.org/docs/latest/rules/grouped-accessor-pairs, https://eslint.org/docs/latest/rules/default-param-last, https://eslint.org/docs/latest/rules/consistent-this, https://eslint.org/docs/latest/rules/default-case-last, https://eslint.org/docs/latest/rules/complexity, https://eslint.style/rules/brace-style, https://eslint.org/docs/latest/rules/brace-style, https://eslint.org/docs/latest/rules/arrow-body-style, https://eslint.style/rules/function-call-argument-newline, https://eslint.org/docs/latest/rules/function-call-argument-newline, https://eslint.style/rules/dot-location, https://eslint.org/docs/latest/rules/dot-location, https://eslint.org/docs/latest/rules/for-direction, https://eslint.style/rules/block-spacing, https://eslint.org/docs/latest/rules/block-spacing, https://eslint.org/docs/latest/rules/id-match, https://eslint.style/rules/function-paren-newline, https://eslint.org/docs/latest/rules/function-paren-newline, https://eslint.style/rules/comma-style, https://eslint.org/docs/latest/rules/comma-style, https://eslint.org/docs/latest/rules/curly, https://eslint.style/rules/linebreak-style, https://eslint.org/docs/latest/rules/linebreak-style, https://eslint.org/docs/latest/rules/id-length, https://eslint.org/docs/latest/rules/func-name-matching, https://eslint.org/docs/latest/rules/max-nested-callbacks, https://eslint.style/rules/computed-property-spacing, https://eslint.org/docs/latest/rules/computed-property-spacing, https://eslint.org/docs/latest/rules/func-style, https://eslint.style/rules/function-call-spacing, https://eslint.org/docs/latest/rules/func-call-spacing, https://eslint.style/rules/indent, https://eslint.org/docs/latest/rules/indent, https://eslint.org/docs/latest/rules/consistent-return, https://eslint.org/docs/latest/rules/max-classes-per-file, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/handle-callback-err.md, https://eslint.org/docs/latest/rules/handle-callback-err, https://eslint.style/rules/key-spacing, https://eslint.org/docs/latest/rules/key-spacing, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/global-require.md, https://eslint.org/docs/latest/rules/global-require, https://eslint.org/docs/latest/rules/func-names, https://eslint.style/rules/lines-around-comment, https://eslint.org/docs/latest/rules/lines-around-comment, https://eslint.style/rules/generator-star-spacing, https://eslint.org/docs/latest/rules/generator-star-spacing, https://eslint.style/rules/keyword-spacing, https://eslint.org/docs/latest/rules/keyword-spacing, https://eslint.org/docs/latest/rules/id-denylist, https://eslint.style/rules/line-comment-position, https://eslint.org/docs/latest/rules/line-comment-position, https://eslint.org/docs/latest/rules/max-depth, https://eslint.style/rules/implicit-arrow-linebreak, https://eslint.org/docs/latest/rules/implicit-arrow-linebreak, https://eslint.org/blog/2020/07/eslint-v7.5.0-released/#deprecating-id-blacklist, https://eslint.org/docs/rules/id-denylist, https://eslint.org/docs/latest/rules/id-blacklist, https://eslint.org/docs/latest/rules/max-lines, https://eslint.org/docs/latest/rules/logical-assignment-operators, https://eslint.style/rules/max-statements-per-line, https://eslint.org/docs/latest/rules/max-statements-per-line, https://eslint.style/rules/eol-last, https://eslint.org/docs/latest/rules/eol-last, https://eslint.org/docs/latest/rules/indent-legacy, https://eslint.org/docs/latest/rules/max-lines-per-function, https://eslint.style/rules/multiline-ternary, https://eslint.org/docs/latest/rules/multiline-ternary, https://eslint.org/docs/latest/rules/max-params, https://eslint.org/docs/latest/rules/init-declarations, https://eslint.org/docs/latest/rules/no-alert, https://eslint.org/docs/latest/rules/no-class-assign, https://eslint.org/docs/latest/rules/getter-return, https://eslint.org/docs/latest/rules/lines-around-directive, https://eslint.org/blog/2017/06/eslint-v4.0.0-released/, https://eslint.org/docs/latest/rules/padding-line-between-statements#examples, https://eslint.style/rules/padding-line-between-statements, https://eslint.org/docs/latest/rules/newline-after-var, https://eslint.style/rules/newline-per-chained-call, https://eslint.org/docs/latest/rules/newline-per-chained-call, https://eslint.org/docs/latest/rules/no-debugger, https://eslint.org/docs/latest/rules/no-async-promise-executor, https://eslint.org/docs/latest/rules/new-cap, https://eslint.org/docs/latest/rules/no-array-constructor, https://eslint.org/docs/latest/rules/no-caller, https://eslint.org/docs/latest/rules/no-cond-assign, https://262.ecma-international.org/5.1/#sec-11.9.3, https://eslint.org/docs/latest/rules/no-constant-binary-expression, https://eslint.org/docs/latest/rules/no-case-declarations, https://eslint.org/docs/latest/rules/no-const-assign, https://eslint.org/docs/latest/rules/no-bitwise, https://eslint.org/docs/latest/rules/newline-before-return, https://eslint.org/docs/latest/rules/no-console, https://eslint.org/docs/latest/rules/no-constant-condition, https://eslint.org/docs/latest/rules/no-await-in-loop, https://eslint.style/rules/lines-between-class-members, https://eslint.org/docs/latest/rules/lines-between-class-members, https://eslint.org/docs/latest/rules/no-constructor-return, https://eslint.style/rules/no-confusing-arrow, https://eslint.org/docs/latest/rules/no-confusing-arrow, https://eslint.org/docs/latest/rules/no-empty-function, https://eslint.org/docs/latest/rules/no-control-regex, https://eslint.org/docs/latest/rules/no-div-regex, https://eslint.org/docs/latest/rules/no-dupe-args, https://eslint.org/docs/latest/rules/no-catch-shadow, https://eslint.org/blog/2018/07/eslint-v5.1.0-released/, https://eslint.org/docs/rules/no-shadow, https://eslint.org/docs/latest/rules/no-continue, https://eslint.style/rules/multiline-comment-style, https://eslint.org/docs/latest/rules/multiline-comment-style, https://eslint.org/docs/latest/rules/no-else-return, https://eslint.org/docs/latest/rules/no-dupe-class-members, https://eslint.org/docs/latest/rules/max-statements, https://eslint.org/docs/latest/rules/no-global-assign, https://eslint.org/docs/latest/rules/no-ex-assign, https://eslint.org/docs/latest/rules/no-duplicate-imports, https://eslint.org/docs/latest/rules/no-eval, https://eslint.org/docs/latest/rules/no-extend-native, https://eslint.org/docs/latest/rules/no-empty-pattern, https://eslint.org/docs/latest/rules/no-eq-null, https://eslint.org/docs/latest/rules/no-dupe-else-if, https://eslint.org/docs/latest/rules/no-import-assign, https://eslint.org/docs/latest/rules/no-empty-static-block, https://eslint.org/docs/latest/rules/no-implicit-coercion, https://eslint.org/docs/latest/rules/no-func-assign, https://eslint.org/docs/latest/rules/no-compare-neg-zero, https://eslint.org/docs/latest/rules/no-delete-var, https://eslint.org/docs/latest/rules/no-native-reassign, https://eslint.org/blog/2016/08/eslint-v3.3.0-released/#deprecated-rules, https://eslint.org/docs/rules/no-global-assign, https://eslint.org/docs/latest/rules/no-dupe-keys, https://eslint.org/docs/latest/rules/no-empty, https://eslint.org/docs/latest/rules/no-inline-comments, https://eslint.style/rules/no-extra-parens, https://eslint.org/docs/latest/rules/no-extra-parens, foo.name, https://eslint.org/docs/latest/rules/no-extra-bind, https://eslint.org/docs/latest/rules/no-extra-label, https://eslint.org/docs/latest/rules/no-empty-character-class, https://eslint.org/docs/latest/rules/no-invalid-regexp, https://eslint.org/docs/latest/rules/no-extra-boolean-cast, https://eslint.org/docs/latest/rules/no-implied-eval, https://eslint.org/docs/latest/rules/no-invalid-this, https://eslint.org/docs/latest/rules/no-fallthrough, https://eslint.org/docs/latest/rules/no-inner-declarations, https://eslint.style/rules/no-floating-decimal, https://eslint.org/docs/latest/rules/no-floating-decimal, https://eslint.org/docs/latest/rules/no-irregular-whitespace, https://eslint.style/rules/max-len, https://eslint.org/docs/latest/rules/max-len, https://eslint.style/rules/no-extra-semi, https://eslint.org/docs/latest/rules/no-extra-semi, https://eslint.org/docs/latest/rules/no-octal-escape, https://eslint.style/rules/no-mixed-operators, https://eslint.org/docs/latest/rules/no-mixed-operators, https://eslint.org/docs/latest/rules/no-negated-condition, https://eslint.org/docs/latest/rules/no-loss-of-precision, https://eslint.org/docs/latest/rules/no-duplicate-case, https://eslint.style/rules/new-parens, https://eslint.org/docs/latest/rules/new-parens, https://eslint.org/docs/latest/rules/no-negated-in-lhs, https://eslint.org/docs/rules/no-unsafe-negation, https://eslint.org/docs/latest/rules/no-magic-numbers, https://eslint.org/docs/latest/rules/no-lonely-if, https://eslint.org/docs/latest/rules/no-new-wrappers, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-mixed-requires.md, https://eslint.org/docs/latest/rules/no-mixed-requires, https://eslint.org/docs/latest/rules/no-multi-assign, https://eslint.org/docs/latest/rules/no-new-func, https://eslint.org/docs/latest/rules/no-labels, https://eslint.org/docs/latest/rules/no-prototype-builtins, https://eslint.org/docs/latest/rules/no-nested-ternary, https://github.com/eslint/eslint/pull/17282#issuecomment-1592795923, https://eslint.org/docs/latest/rules/no-promise-executor-return, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-deprecated-api.md, https://eslint.org/docs/latest/rules/no-buffer-constructor, https://eslint.org/docs/latest/rules/no-nonoctal-decimal-escape, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-process-exit.md, https://eslint.org/docs/latest/rules/no-process-exit, https://eslint.org/docs/latest/rules/no-misleading-character-class, https://github.com/eslint/eslint/pull/17515, https://eslint.org/docs/latest/rules/no-self-assign, https://eslint.org/docs/latest/rules/no-new-symbol, https://eslint.org/docs/latest/use/migrate-to-9.0.0#eslint-recommended, https://eslint.org/docs/latest/rules/no-new-native-nonconstructor, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-restricted-require.md, https://eslint.org/docs/latest/rules/no-restricted-modules, https://eslint.org/docs/latest/rules/no-lone-blocks, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-new-require.md, https://eslint.org/docs/latest/rules/no-new-require, https://eslint.org/docs/latest/rules/no-sparse-arrays, https://eslint.style/rules/no-mixed-spaces-and-tabs, https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs, https://eslint.org/docs/latest/rules/no-obj-calls, https://eslint.org/docs/latest/rules/no-restricted-exports, https://eslint.org/docs/latest/rules/no-new-object, https://eslint.org/blog/2023/09/eslint-v8.50.0-released/, https://eslint.org/docs/rules/no-object-constructor, https://eslint.org/docs/latest/rules/no-multi-str, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-path-concat.md, https://eslint.org/docs/latest/rules/no-path-concat, https://eslint.org/docs/latest/rules/no-param-reassign, https://eslint.org/docs/latest/rules/no-script-url, https://eslint.org/docs/latest/rules/no-return-assign, https://eslint.style/rules/no-multi-spaces, https://eslint.org/docs/latest/rules/no-multi-spaces, https://eslint.org/docs/latest/rules/no-new, https://eslint.org/docs/latest/rules/no-redeclare, https://eslint.org/docs/latest/rules/no-implicit-globals, https://eslint.org/docs/latest/rules/no-octal, https://eslint.org/docs/latest/rules/no-restricted-globals, https://eslint.org/docs/latest/rules/no-plusplus, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-process-env.md, https://eslint.org/docs/latest/rules/no-process-env, https://eslint.style/rules/no-multiple-empty-lines, https://eslint.org/docs/latest/rules/no-multiple-empty-lines, https://eslint.org/docs/latest/rules/no-restricted-properties, https://eslint.org/docs/latest/rules/no-restricted-imports, https://github.com/eslint-community/eslint-plugin-n/tree/master/docs/rules/no-sync.md, https://eslint.org/docs/latest/rules/no-sync, https://eslint.org/docs/latest/rules/no-proto, https://eslint.style/rules/no-tabs, https://eslint.org/docs/latest/rules/no-tabs, https://eslint.org/docs/latest/rules/no-spaced-func, https://eslint.org/docs/latest/rules/no-object-constructor, https://eslint.org/docs/latest/rules/no-unused-expressions, https://eslint.org/docs/latest/rules/no-useless-concat, https://eslint.org/docs/latest/rules/no-label-var, https://eslint.org/docs/latest/rules/no-regex-spaces, https://eslint.org/docs/latest/rules/no-shadow, https://eslint.org/docs/latest/rules/no-unsafe-finally, https://eslint.org/docs/latest/rules/no-iterator, https://eslint.org/docs/latest/rules/no-unreachable, https://eslint.org/docs/latest/rules/no-useless-call, https://eslint.org/docs/latest/rules/no-unsafe-optional-chaining, https://eslint.org/docs/latest/rules/no-self-compare, https://eslint.org/docs/latest/rules/no-unassigned-vars, https://eslint.org/docs/latest/rules/no-underscore-dangle, https://eslint.org/docs/latest/rules/no-unreachable-loop, https://eslint.org/docs/latest/rules/no-useless-escape, https://eslint.org/docs/latest/rules/no-unused-labels, https://eslint.org/docs/latest/rules/no-undefined, https://eslint.style/rules/no-trailing-spaces, https://eslint.org/docs/latest/rules/no-trailing-spaces, https://eslint.org/docs/latest/rules/no-undef-init, https://eslint.org/docs/latest/rules/no-loop-func, https://eslint.org/docs/latest/rules/no-useless-constructor, https://eslint.org/docs/latest/rules/object-shorthand, https://eslint.org/docs/latest/rules/no-unmodified-loop-condition, https://eslint.org/docs/latest/rules/no-throw-literal, https://eslint.org/docs/latest/rules/no-use-before-define, https://eslint.org/docs/latest/rules/no-unneeded-ternary, https://eslint.org/docs/latest/rules/no-setter-return, https://eslint.org/docs/latest/rules/no-var, https://eslint.org/docs/latest/rules/no-useless-return, https://eslint.org/docs/latest/rules/no-undef, https://eslint.org/docs/latest/rules/no-return-await, https://eslint.org/docs/latest/rules/no-with, https://eslint.org/docs/latest/rules/no-template-curly-in-string, https://eslint.org/docs/latest/rules/no-restricted-syntax, https://eslint.org/docs/latest/rules/no-useless-assignment, https://eslint.org/docs/latest/rules/no-shadow-restricted-names, https://eslint.org/docs/latest/rules/no-unused-private-class-members, https://eslint.org/docs/latest/rules/no-unexpected-multiline, https://eslint.org/docs/latest/rules/no-useless-rename, https://eslint.org/docs/latest/rules/no-unsafe-negation, https://eslint.org/docs/latest/rules/no-ternary, https://eslint.org/docs/latest/rules/operator-assignment, https://eslint.org/docs/latest/rules/no-void, https://eslint.org/docs/latest/rules/no-useless-catch, https://eslint.org/docs/latest/rules/prefer-exponentiation-operator, https://eslint.org/docs/latest/rules/no-useless-computed-key, https://eslint.org/docs/latest/rules/no-sequences, https://eslint.org/docs/latest/rules/no-unused-vars, https://eslint.style/rules/no-whitespace-before-property, https://eslint.org/docs/latest/rules/no-whitespace-before-property, https://eslint.org/docs/latest/rules/one-var, https://eslint.style/rules/object-curly-newline, https://eslint.org/docs/latest/rules/object-curly-newline, https://eslint.org/docs/latest/rules/no-useless-backreference, https://eslint.org/docs/latest/rules/prefer-object-has-own, https://eslint.style/rules/object-property-newline, https://eslint.org/docs/latest/rules/object-property-newline, https://eslint.org/docs/latest/rules/no-warning-comments, https://eslint.style/rules/padded-blocks, https://eslint.org/docs/latest/rules/padded-blocks, https://eslint.org/docs/latest/rules/prefer-promise-reject-errors, https://eslint.style/rules/one-var-declaration-per-line, https://eslint.org/docs/latest/rules/one-var-declaration-per-line, https://eslint.org/docs/latest/rules/prefer-named-capture-group, https://eslint.org/docs/latest/rules/padding-line-between-statements, https://eslint.style/rules/nonblock-statement-body-position, https://eslint.org/docs/latest/rules/nonblock-statement-body-position, https://eslint.style/rules/operator-linebreak, https://eslint.org/docs/latest/rules/operator-linebreak, https://eslint.org/docs/latest/rules/prefer-const, https://eslint.style/rules/object-curly-spacing, https://eslint.org/docs/latest/rules/object-curly-spacing, https://eslint.org/docs/latest/rules/prefer-reflect, Function.prototype.call, https://eslint.org/docs/latest/rules/prefer-object-spread, https://eslint.org/docs/latest/rules/prefer-regex-literals, MetaProperty.property, https://eslint.org/docs/latest/rules/prefer-arrow-callback, https://eslint.org/docs/latest/rules/no-this-before-super, https://eslint.org/docs/latest/rules/radix, https://eslint.style/rules/quote-props, https://eslint.org/docs/latest/rules/quote-props, https://eslint.org/docs/latest/rules/require-atomic-updates, https://eslint.org/docs/latest/rules/prefer-rest-params, https://eslint.org/docs/latest/rules/require-unicode-regexp, https://eslint.style/rules/space-in-parens, https://eslint.org/docs/latest/rules/space-in-parens, https://eslint.org/docs/latest/rules/preserve-caught-error, https://typescript-eslint.io/packages/type-utils/type-or-value-specifier/, https://github.com/eslint/eslint/pull/19913#discussion_r2192608593, https://github.com/eslint/eslint/discussions/16540, https://github.com/microsoft/TypeScript/blob/main/src/lib/es2022.error.d.ts, https://eslint.org/docs/latest/rules/prefer-template, https://eslint.org/docs/latest/rules/require-yield, https://eslint.style/rules/semi-style, https://eslint.org/docs/latest/rules/semi-style, https://eslint.org/docs/latest/rules/unicode-bom, http://www.ecma-international.org/ecma-262/6.0/#sec-directive-prologues-and-the-use-strict-directive, https://eslint.style/rules/switch-colon-spacing, https://eslint.org/docs/latest/rules/switch-colon-spacing, https://eslint.style/rules/space-before-blocks, https://eslint.org/docs/latest/rules/space-before-blocks, https://eslint.org/docs/latest/rules/prefer-numeric-literals, https://eslint.org/docs/latest/rules/prefer-destructuring, https://jex.im/regulex/#, https://eslint.style/rules/spaced-comment, https://eslint.org/docs/latest/rules/spaced-comment, https://eslint.org/docs/latest/rules/sort-imports, https://eslint.org/docs/latest/rules/use-isnan, https://eslint.style/rules/space-before-function-paren, https://eslint.org/docs/latest/rules/space-before-function-paren, https://eslint.style/rules/space-unary-ops, https://eslint.org/docs/latest/rules/space-unary-ops, https://eslint.style/rules/semi, https://eslint.org/docs/latest/rules/semi, https://eslint.style/rules/template-curly-spacing, https://eslint.org/docs/latest/rules/template-curly-spacing, https://eslint.style/rules/space-infix-ops, https://eslint.org/docs/latest/rules/space-infix-ops, https://eslint.org/docs/latest/rules/symbol-description, https://eslint.org/docs/latest/rules/vars-on-top, https://eslint.style/rules/template-tag-spacing, https://eslint.org/docs/latest/rules/template-tag-spacing, https://eslint.org/docs/latest/rules/valid-typeof, https://eslint.org/docs/latest/rules/prefer-spread, https://eslint.style/rules/semi-spacing, https://eslint.org/docs/latest/rules/semi-spacing, https://eslint.style/rules/rest-spread-spacing, https://eslint.org/docs/latest/rules/rest-spread-spacing, https://eslint.style/rules/yield-star-spacing, https://eslint.org/docs/latest/rules/yield-star-spacing, https://eslint.org/docs/latest/rules/strict, https://github.com/eslint/eslint/issues/8020, https://github.com/estree/estree/blob/14df8a024956ea289bd55b9c2226a1d5b8a473ee/es5.md#regexpliteral, https://github.com/estree/estree/blob/14df8a024956ea289bd55b9c2226a1d5b8a473ee/es2020.md#bigintliteral, https://github.com/tc39/proposal-static-class-features, https://eslint.style/rules/wrap-regex, https://eslint.org/docs/latest/rules/wrap-regex, https://eslint.style/rules/wrap-iife, https://eslint.org/docs/latest/rules/wrap-iife, https://eslint.org/docs/latest/rules/yoda, https://eslint.org/docs/latest/rules/sort-vars, https://eslint.org/docs/latest/rules/sort-keys, https://eslint.style/rules/quotes, https://eslint.org/docs/latest/rules/quotes, https://eslint.org/docs/latest/rules/require-await, https://eslint.org/docs/latest/use/configure/migration-guide#ignore-files, https://eslint.org/chat, https://eslint.org/docs/latest/use/configure/migration-guide#import-plugins-and-custom-parsers, https://eslint.org/docs/latest/use/configure/migration-guide#use-eslintrc-configs-in-flat-config, https://eslint.org/docs/latest/use/troubleshooting., https://eslint.org/docs/latest/use/configure/rules#use-configuration-files, https://eslint.org/docs/latest/use/configure/ignore, https://eslint.org/docs/latest/use/configure/configuration-files#specify-files-with-arbitrary-extensions, https://eslint.org/docs/latest/extend/custom-parsers#meta-data-in-custom-parsers, https://eslint.org/chat/help, https://eslint.org/docs/latest/use/command-line-interface#--print-config, https://eslint.org/docs/latest/use/configure/rules#rule-severities, https://eslint.org/docs/latest/use/configure/rules, https://eslint.org/docs/latest/use/configure/, https://github.com/eslint/eslint/blob/v8.57.0/conf/config-schema.js, https://eslint.org/docs/latest/use/configure/language-options#specifying-parser-options, https://eslint.org/docs/latest/use/configure/migration-guide#configure-language-options, https://eslint.org/docs/latest/use/configure/migration-guide#predefined-and-shareable-configs, https://eslint.org/docs/latest/use/configure/migration-guide#linter-options, https://eslint.org/docs/latest/use/configure/migration-guide#glob-based-configs, https://eslint.org/docs/latest/use/configure/migration-guide#custom-parsers, https://eslint.org/docs/latest/use/configure/migration-guide

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What are URL strings?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Review all remote URLs to ensure they are intentional, pointing to trusted sources, and not being used for data exfiltration or loading untrusted code at runtime.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Debug access: npm eslint in module repl

Module: repl

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is debug access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Removing the use of debug will reduce the risk of any reflection and dynamic code execution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Debug access: npm eslint in module module

Module: module

Location: Package overview

From: ?npm/eslint@10.0.0

ℹ Read more on: This package | This alert | What is debug access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Removing the use of debug will reduce the risk of any reflection and dynamic code execution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Embedded URLs or IPs: npm lerna

URLs: https://pnpm.io/workspaces, https://conventionalcommits.org, https://docs.npmjs.com/getting-started/using-two-factor-authentication, https://registry.npmjs.org/, https://pnpm.io/cli/install, 0.0.0.0, https://pnpm.io/cli/add, CHANGELOG.md, https://gitlab.com/api/v4, user.email, user.name, https://lerna.js.org/docs/getting-started, https://docs.npmjs.com/creating-and-viewing-access-tokens, https://github.com/lerna/lerna/issues/new/choose, https://registry.yarnpkg.com, https://choosealicense.com, https://docs.npmjs.com/cli/v9/configuring-npm/package-json#private, https://github.com/lerna/lerna, https://lerna.js.org/docs/concepts/task-pipeline-configuration, https://lerna.js.org/docs/lerna6-obsolete-options

Location: Package overview

From: ?npm/lerna@6.5.0

ℹ Read more on: This package | This alert | What are URL strings?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Review all remote URLs to ensure they are intentional, pointing to trusted sources, and not being used for data exfiltration or loading untrusted code at runtime.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/lerna@6.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates eslint to a major version (10.0.0) and lerna to 6.5.0. The eslint upgrade is a major breaking change that is incompatible with the current legacy configuration and conflicts with peerDependencies in several workspace packages pinned to 8.56.0. This will likely break the linting CI. Additionally, the yarn.lock file was not updated, which must be resolved manually.

"@typescript-eslint/parser": "6.19.0",
"codecov": "3.8.3",
"eslint": "8.56.0",
"eslint": "10.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading eslint to 10.0.0 is a major breaking change that is incompatible with the repository's current legacy configuration (.eslintrc.js). Furthermore, workspace packages like config/eslint-config-ironfish and config/eslint-plugin-ironfish have peerDependencies strictly pinned to 8.56.0. This mismatch will cause dependency resolution failures and break the linting pipeline. If the intent is to fix a vulnerability in ajv, consider using the resolutions field or staying within the 8.x range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants