Merged
Conversation
CathalMullan
force-pushed
the
berry-nixpkgs
branch
14 times, most recently
from
293ee5b to
8e11ca8
Compare
CathalMullan
force-pushed
the
berry-nixpkgs
branch
from
8e11ca8 to
881c251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll wait until it hits unstable before merging.
EDIT: Hit a few issues with v1.0.0, might be too early for this.
EDIT: The actual berry hook in v1.2.1 seems to work. But our Electron downloader isn't working anymore. Need to figure out why.
UPDATE: It works!
Need to wait for: https://nixpk.gs/pr-tracker.html?pr=401813
TODO: Switch back to nixpkgs-unstable