fix cpl_scalars#6
Merged
DusanJovic-NOAA merged 26 commits intoJul 17, 2024
Merged
Conversation
This reverts commit 491b5c6.
* HR4 GWD update for files GFS_typedefs.F90 GFS_typedefs.meta * update files GFS_typedefs.F90 GFS_typedefs.meta * remove psl_ from files GFS_typedefs.F90 GFS_typedefs.meta * HR4 Gravity Wave Drag Update * update code GFS_typedefs.F90 for GWD and Noahmp HR4 * point to PR#549 of ccpp-framework * retract the changes from the Noahmp model --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
* error out of all 3 spatial indices are not present * add check for scalar_id = 0
* atmos_cubed_sphere - bug fix to address debug mode crashes caused by floating-point exception in subroutine a2b_ord2 in model/a2b_edge.F90
Owner
|
@DeniseWorthen Why do I see 7 files changed, it should be only 2, correct? |
Author
|
I don't know...when I compare my branch against develop, I see only 2 files https://github.com/NOAA-EMC/fv3atm/compare/develop...DeniseWorthen:fv3atm:bugfix/fixcplscalars?expand=1 |
Owner
|
Ok. Can you remove "Draft mode" and I'll merge it. |
Owner
|
@DeniseWorthen Please double check this merge commit c2f71ad |
Author
|
Yes, that looks fine. Thanks! |
DusanJovic-NOAA
added a commit
that referenced
this pull request
Jul 30, 2024
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0 * Fixed bug in aux2d dimensions for GFS meta file. * Pass return code from diagnose_cplFields back to caller * Skip 'cpl_scalars' field when dumping export state * fix fhzero for GEFS * fix cpl_scalars (#6) * fix issues w/ cplscalars * error out of all 3 spatial indices are not present * add check for scalar_id = 0 * modify for timeslices and times (#7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs