Acsnow restart fix#11
Merged
DusanJovic-NOAA merged 4 commits intoMay 27, 2025
Merged
Conversation
Author
|
@DusanJovic-NOAA @tanyasmirnova could you please review this PR? thanks! |
tanyasmirnova
left a comment
tanyasmirnova
left a comment
There was a problem hiding this comment.
@JiliDong-NOAA Jili, looks good to me. However, I don't have an option to approve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix the restart reproducibility of snow water equivalent accumulation by adding acsnow_land and acsnow_ice to the RESTART sfc_data.nc. I am not entirely sure if nvar2r or nvar2m need to be updated. Currently I choose to update nvar2r. And it seems working fine.
Issue(s) addressed
Restore the restart reproducibility of snow water equivalent accumulation
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs