Skip to content

Use standard error response for failed mTLS auth #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Use standard error response for failed mTLS auth #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions identity-server/src/IdentityServer/Hosting/MutualTlsEndpointMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public async Task Invoke(HttpContext context, IAuthenticationSchemeProvider sche

if (result.Succeeded)
{
var path = ProtocolRoutePaths.ConnectPathPrefix +
subPath.ToString().EnsureLeadingSlash();
var path = ProtocolRoutePaths.ConnectPathPrefix + subPath.ToString().EnsureLeadingSlash();
path = path.EnsureLeadingSlash();

_sanitizedLogger.LogDebug("Rewriting MTLS request from: {oldPath} to: {newPath}",
Expand All @@ -96,16 +95,26 @@ public async Task Invoke(HttpContext context, IAuthenticationSchemeProvider sche

private async Task<AuthenticateResult> TriggerCertificateAuthentication(HttpContext context)
{
var x509AuthResult =
await context.AuthenticateAsync(_options.MutualTls.ClientCertificateAuthenticationScheme);
var x509AuthResult = await context.AuthenticateAsync(_options.MutualTls.ClientCertificateAuthenticationScheme);

if (!x509AuthResult.Succeeded)
{
_sanitizedLogger.LogDebug("MTLS authentication failed, error: {error}.",
x509AuthResult.Failure?.Message);
await context.ForbidAsync(_options.MutualTls.ClientCertificateAuthenticationScheme);
_sanitizedLogger.LogDebug("MTLS authentication failed, error: {error}.", x509AuthResult.Failure?.Message);
context.Response.StatusCode = StatusCodes.Status400BadRequest;
await context.Response.WriteJsonAsync(new MtlsErrorResponse
{
error = "invalid_client",
error_description = "mTLS authentication failed."
});
}

return x509AuthResult;
}

class MtlsErrorResponse
{
public string error { get; set; }
public string error_description { get; set; }
}

}
Loading
Loading