Do not issue TokenIssuedFailureEvent for use_dpop_nonce error #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
approved these changes
Jan 28, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not issue a TokenIssuedFailureEvent when a
use_dpop_nonceerror occurs as this is an expected occurrence in the case of a client obtaining the nonce from the server when usingDPoP. A debug level log statement has been left in to help troubleshooting buggy client implementations. Additionally, telemetry events have been left as well as those don't add noise in the distracting way the failure events do to logs.