[Based on #766] add equalable content provider #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check old text highlight to update item which unnecessary highlighted remove toRegex() because it crushes when '+' is passed
takahirom
force-pushed
the
feature/issue550_add_equalable_content_provider
branch
from
a701c2c to
372307d
Compare
jmatsu-bot
reviewed
Feb 3, 2019
| @@ -98,7 +98,7 @@ class SearchFragment : DaggerFragment() { | |||
| result.query | |||
| ) | |||
| }.sortedBy { it.speaker.name.toUpperCase() } | |||
| setHeader(HeaderItem(requireContext().getString(R.string.speaker_label))) | |||
| setHeader(SearchSectionHeaderItem(requireContext().getString(R.string.speaker_label))) | |||
There was a problem hiding this comment.
| 🚫 | Exceeded max line length (100) (cannot be auto-corrected) |
jmatsu-bot
reviewed
Feb 3, 2019
| @@ -136,7 +136,7 @@ class SearchFragment : DaggerFragment() { | |||
| else -> StickyHeaderItemDecoration.DEFAULT_TITLE | |||
| } | |||
| } | |||
| setHeader(HeaderItem(requireContext().getString(R.string.session_title))) | |||
| setHeader(SearchSectionHeaderItem(requireContext().getString(R.string.session_title))) | |||
There was a problem hiding this comment.
| 🚫 | Exceeded max line length (100) (cannot be auto-corrected) |
Apk comparision results
Generated by 🚫 Danger |
|
Asserted successfully. 💯 Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)