Fix Shell Android navigation icon flicker during push/pop animation - #1
Draft
Dreamescaper with Copilot wants to merge 1 commit into
Draft
Fix Shell Android navigation icon flicker during push/pop animation#1Dreamescaper with Copilot wants to merge 1 commit into
Dreamescaper with Copilot wants to merge 1 commit into
Conversation
…tead of backButtonVisible in ShellToolbarTracker Agent-Logs-Url: https://github.com/Dreamescaper/maui/sessions/060e5fa4-1693-4b26-be73-469dffa70d0a Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Dreamescaper
April 16, 2026 21:39
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android Shell with a Flyout, pushing a page causes the hamburger icon to briefly appear during the animation before switching to the back arrow once the animation completes. The same flicker occurs on pop.
Root Cause
PR dotnet#28187 (Issue21646 fix) introduced a regression in
ShellToolbarTracker.UpdateLeftBarButtonItem. The icon-setup conditions were changed to usebackButtonVisible = _toolbar.BackButtonVisible, but this value is copied from the global toolbar atOnCreateViewtime — which reflects the previous (root) page's stale state (BackButtonVisible = false). The global toolbar isn't updated untilshell.Navigatedfires after the animation completes.Fix
Replace
backButtonVisiblewithbackButtonVisibleFromBehaviorin the four icon-setup conditions inShellToolbarTracker.cs:Both variables agree after navigation completes, so post-animation behavior is unchanged. The Issue21646 case (
BackButtonBehavior.IsVisible = false→ hamburger stays visible) continues to work correctly.