Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sys_alarm第二版 #710

Merged
merged 35 commits into from
Apr 16, 2024
Merged

feat: sys_alarm第二版 #710

merged 35 commits into from
Apr 16, 2024

Conversation

smallcjy
Copy link
Contributor

@smallcjy smallcjy commented Apr 9, 2024

修改pcb中alarm结构和alarmTimer的结构得到更好的封装性，因为调用实现基本重构重写，所以重新pr一次

@dragonosbot
Copy link

感谢您的pull request，欢迎加入！🎉 DragonOS社区很兴奋地期待审核您的更改，您将在接下来的两周内收到 @fslongjin @GnoCiYeH @chiichen (NB. this repo may be misconfigured) 的回复。💬😊

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-等待审查 and S-等待作者修改) stays updated, invoking these commands when appropriate:

  • @dragonosbot author: 审查结束后，PR的作者应检查评论并采取相应行动
  • @dragonosbot review: 作者已完成修改，将此PR提交给reviewer进行审阅，此PR将再次在审阅者队列中排队

@dragonosbot dragonosbot added the S-等待审查 Status: 等待assignee以及相关方的审查。 label Apr 9, 2024
@fslongjin fslongjin requested a review from chiichen April 9, 2024 14:20
chiichen
chiichen requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@chiichen chiichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在second，jiffies都是u32混用，然后用一堆散装函数做转换我觉得不太好，我觉得改成，second/ms/ns都用core::time::duration,它可以帮你屏蔽掉second/ms/ns互换的这一层逻辑。然后把jiffies封装一个Jiffies(u32)，然后实现 Duration 和 Jiffies 互换的 Trait，这样看起来就很清晰了

@fslongjin
Copy link
Member

@dragonosbot author

@dragonosbot dragonosbot added S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 and removed S-等待审查 Status: 等待assignee以及相关方的审查。 labels Apr 10, 2024
@smallcjy
Copy link
Contributor Author

了解

chiichen
chiichen requested changes Apr 11, 2024
View reviewed changes
@smallcjy smallcjy requested a review from chiichen April 14, 2024 07:26
@smallcjy
Copy link
Contributor Author

@dragonosbot review

@dragonosbot dragonosbot added S-等待审查 Status: 等待assignee以及相关方的审查。 and removed S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 labels Apr 14, 2024
GnoCiYeH
GnoCiYeH requested changes Apr 14, 2024
View reviewed changes
@chiichen chiichen changed the title sys_alarm第二版 feat: sys_alarm第二版 Apr 14, 2024
@smallcjy
Copy link
Contributor Author

@dragonosbot review

fslongjin
fslongjin requested changes Apr 15, 2024
View reviewed changes
@fslongjin
Copy link
Member

#662

@smallcjy
Copy link
Contributor Author

@dragonosbot review

fslongjin
fslongjin requested changes Apr 16, 2024
View reviewed changes
@smallcjy
Copy link
Contributor Author

@dragonosbot review

fslongjin
fslongjin requested changes Apr 16, 2024
View reviewed changes
@smallcjy
Copy link
Contributor Author

@dragonosbot review

@fslongjin fslongjin merged commit fbd63a3 into DragonOS-Community:master Apr 16, 2024
7 checks passed
@smallcjy smallcjy deleted the sys_alarm branch April 25, 2024 05:51
BrahmaMantra pushed a commit to BrahmaMantra/DragonOS that referenced this pull request Dec 9, 2024
@smallcjy @BrahmaMantra
feat: alarm系统调用实现 (DragonOS-Community#710)
75b971d 
* alarm系统调用实现
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnoCiYeH GnoCiYeH GnoCiYeH requested changes

@fslongjin fslongjin fslongjin approved these changes

@chiichen chiichen Awaiting requested review from chiichen

Assignees
No one assigned
Labels
S-等待审查 Status: 等待assignee以及相关方的审查。
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smallcjy @dragonosbot @fslongjin @chiichen @GnoCiYeH