Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix udp bind #676

Merged
merged 3 commits into from
Mar 31, 2024
Merged

fix udp bind #676

merged 3 commits into from
Mar 31, 2024

Conversation

sun5etop
Copy link
Contributor

1.在udpsocket绑定端口的时候,检查绑定端口为0则绑定随机端口。
2.删除在write里检查端口为0的逻辑,应该在bind中检查,与tcpsocket相同。

@dragonosbot
Copy link

感谢您的pull request,欢迎加入!🎉 DragonOS社区很兴奋地期待审核您的更改,您将在接下来的两周内收到 @fslongjin @GnoCiYeH @Chiichen (NB. this repo may be misconfigured) 的回复。💬😊

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-等待审查 and S-等待作者修改) stays updated, invoking these commands when appropriate:

  • @dragonosbot author: 审查结束后,PR的作者应检查评论并采取相应行动
  • @dragonosbot review: 作者已完成修改,将此PR提交给reviewer进行审阅,此PR将再次在审阅者队列中排队

@dragonosbot dragonosbot added the S-等待审查 Status: 等待assignee以及相关方的审查。 label Mar 28, 2024
@yuyi2439
Copy link
Contributor

请说明这样修改解决了什么问题,或者给出参考文章或代码,可以的话添加一个测试用例,可以写在test_socket里

@fslongjin fslongjin merged commit 9d9a098 into DragonOS-Community:master Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-等待审查 Status: 等待assignee以及相关方的审查。
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants