修复了ramfs中move_to的bug #673
Merged
修复了ramfs中move_to的bug #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢您的pull request，欢迎加入！🎉 DragonOS社区很兴奋地期待审核您的更改，您将在接下来的两周内收到 @fslongjin (or someone else) 的回复。💬😊 Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
提交代码之前要使用 |
|
@dragonosbot author |
dragonosbot
added
S-等待作者修改
fslongjin
reviewed
Mar 28, 2024
kernel/src/filesystem/ramfs/mod.rs
Outdated
|
|
||
| //修改其对父节点的引用 | ||
| let mut old_inode = old_inode.0.lock(); | ||
| let target = target.0.lock(); |
There was a problem hiding this comment.
要把target从&Arc转换为Weak并赋值给old_inode.parent,好像就只能上锁后去调用self_ref（还是我太菜了）
* 完善ramfs move_to * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在kernel init时进行了测试，发现了move_to并未修改parent变量，本次pr修复了这个bug（已测试）