Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newport mkisofs - stripped down cdrtools #1464

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mneumann
Copy link
Contributor

@mneumann mneumann commented Dec 6, 2023

Using sysutils/mkisofs instead of sysutils/cdrtools mainly gets rid of various sound-specific dependencies (LAME, VORBIS). This idea is to use this "port" also in nrelease and dillons withpkgs branch.

@mneumann
Copy link
Contributor Author

@tuxillo any idea why the CI build fails? what am I doing wrong?

@liweitianux
Copy link
Member

It's the INDEX generation that's currently failing, so no worries ;)

On the other hand, I don't think you should add the STATUS file; it will be auto added by the builder, if i understand correctly.

It should be auto added by the builder
@tuxillo
Copy link
Member

tuxillo commented Dec 17, 2023

The STATUS file is needed because it is a DPORT, we have the full definition in DeltaPorts. It probably failed before you removed the STATUS file because we're missing some case handling in the script. I'll have to have a look.

This reverts commit 0f05878.

The STATUS file is needed because it is a DPORT :)
@mneumann
Copy link
Contributor Author

@tuxillo if you think this port is worth (maybe under a different name), feel free to merge. it should drop quite a few dependencies. Alternative would be to create a "flavor" of cdrtools.

@tuxillo
Copy link
Member

tuxillo commented Feb 19, 2024

@tuxillo if you think this port is worth (maybe under a different name), feel free to merge. it should drop quite a few dependencies. Alternative would be to create a "flavor" of cdrtools.

hmmm, maybe creating a flavor would be actually better? not sure what would be the correct approach.

@mneumann
Copy link
Contributor Author

mneumann commented Jun 2, 2024

@tuxillo: Flavor would work, though it'd be a bit more "complex" to implement and it would make it more difficult to keep in sync with FreeBSD, unless they adopt the same patches.

@daftaupe
Copy link
Member

daftaupe commented Aug 6, 2024

@mneumann from what I understand, the port is going to evolve together when cdrtools / schilybase are updated, so we don't have to sync it manually everytime they change version ?

If that's the case, I'm ok with that port, it makes sense to not bring all the dependencies in the base image.

@mneumann
Copy link
Contributor Author

mneumann commented Aug 7, 2024

@daftaupe yes, it includes Makefile.master from schilybase. So, it will evolve like cdrtools when schilybase gets an update. it might need "tweaking" iff new binaries would be added to schilybase, as we remove them in post-install. Though that is highly unlikely...

@mneumann
Copy link
Contributor Author

mneumann commented Aug 7, 2024

@daftaupe yeah, the dependency list is huge. lots of sound-related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants