Repository navigation
Update naming rules to support records - #3209
Merged
Merged
Conversation
sharwell
commented
Sep 26, 2020
Comment on lines
+47
to
+51
| // /0/Test0.cs(2,15): warning SA1300: Element 'r' should begin with an uppercase letter | ||
| Diagnostic().WithLocation(0).WithArguments("r"), | ||
|
|
||
| // /0/Test0.cs(2,15): warning SA1300: Element 'r' should begin with an uppercase letter | ||
| Diagnostic().WithLocation(0).WithArguments("r"), |
Member
Author
There was a problem hiding this comment.
📝 This is a bug in the analyzer driver
sharwell
force-pushed
the
positional-record
branch
from
September 26, 2020 22:18
939c834 to
ee612f6
Compare
sharwell
marked this pull request as draft
September 26, 2020 22:44
sharwell
marked this pull request as ready for review
September 26, 2020 23:22
sharwell
force-pushed
the
positional-record
branch
from
September 26, 2020 23:22
ee612f6 to
d6a8075
Compare
Codecov Report
@@ Coverage Diff @@
## master #3209 +/- ##
========================================
Coverage 97.12% 97.13%
========================================
Files 839 841 +2
Lines 104842 104946 +104
Branches 3413 3416 +3
========================================
+ Hits 101828 101937 +109
+ Misses 2099 2095 -4
+ Partials 915 914 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3168
Fixes #3181