Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please avoid node dependency to "natives" module #153

Closed
bpasero opened this issue Apr 10, 2018 · 3 comments
Closed

Please avoid node dependency to "natives" module #153

bpasero opened this issue Apr 10, 2018 · 3 comments

Comments

@bpasero
Copy link

bpasero commented Apr 10, 2018

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

If this is just a devDependency and the module is never loaded in production, then you can ignore this issue and just close it!

More details in microsoft/vscode#47569

Thanks!
Ben
VSCode Team

@Tyriar
Copy link

Tyriar commented Apr 10, 2018

Looks like this will involve getting xqlint to update update-notifier to a more recent version.

@DotJoshJohnson DotJoshJohnson self-assigned this Apr 29, 2018
@DotJoshJohnson DotJoshJohnson added this to the Release: v2.0.0 milestone Apr 29, 2018
DotJoshJohnson added a commit that referenced this issue May 4, 2018
Removes "natives" from dependency tree.

fixes #153
@DotJoshJohnson
Copy link
Owner

Released in v2.0.0-preview.3.

@DotJoshJohnson DotJoshJohnson removed their assignment May 4, 2018
@bpasero
Copy link
Author

bpasero commented May 4, 2018

@DotJoshJohnson thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants