Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension hijacks user focus to Output panel on stderr #22

Open
wconnorwalsh opened this issue Jun 15, 2023 · 0 comments · May be fixed by #23
Open

Extension hijacks user focus to Output panel on stderr #22

wconnorwalsh opened this issue Jun 15, 2023 · 0 comments · May be fixed by #23

Comments

@wconnorwalsh
Copy link

In our development container, we manually configure Doppler by setting the environment variable DOPPLER_CONFIG_DIR. This causes the valueFromEnvironmentNotice CLI function to be called each time a Doppler command is executed.

(Note: this can be irritating when executing doppler run frequently. It would be ideal if this warning could be disabled or only output once per day/session. A separate issue has been opened for this: DopplerHQ/cli#407)

Whenever valueFromEnvironmentNotice is called, it writes a warning to stderr, which opens the VSCode Output panel and moves the user's cursor and focus to that panel. For those using environment variables to configure Doppler, this behavior makes the extension impossible to use.

I recognize the importance of providing error feedback to the user, however, I am not aware of any other VSCode extension that takes control of the user focus in this manner.

I am happy to submit a pull request for this. This can be fixed simply by removing line 97.

if (stderr.length > 0) {
this.outputChannel.append(stderr);
this.outputChannel.show();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant