Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hide-secrets flag for run command #327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement hide-secrets flag for run command #327

wants to merge 2 commits into from

Conversation

remorses
Copy link

Implements #326

@remorses remorses marked this pull request as ready for review August 22, 2022 16:52
@remorses
Copy link
Author

I can add tests for ReplaceTransformer if you want, i copied that code from here

@Piccirello
Copy link
Contributor

I'm having difficulty understanding the practical use case for this, beyond demos. Why would a user want invalid values to be injected? I think a more pragmatic solution would be to support specifying an allowlist of secrets that should be injected (#322).

@remorses
Copy link
Author

This pr does not inject invalid values, it simply hides them from the terminal output, the env variables remain the same

some use cases

  • Making sure CI logs do not contain secrets (anyone that can see your logs could steal your secrets, very dangerous)
  • streaming on twitch or demos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piccirello Piccirello Awaiting requested review from Piccirello

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remorses @Piccirello