Fixed length calculation to successfully parse keys of certificates and added printable string #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added printable string
expose swift values as public var `value`
DominikHorn
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Hi Mats,
Its lovely to see that this old project of mine is actively being used. Thank you very much for making the effort to contribute back. This is greatly appreciated.
One small nit: Please keep the formatting consistent for DERParser+TLV.swift. It is hard to see what actually changed from the diff.
In general, LGTM. Especially like the cleanup/refactoring and added test.
| @@ -9,87 +9,96 @@ import Foundation | |||
| import BigInt | |||
|
|
|||
| extension DERParser { | |||
| /// As documented in https://docs.microsoft.com/en-us/windows/win32/seccertenroll/about-encoded-length-and-value-bytes | |||
There was a problem hiding this comment.
nit: Please keep the formatting consistent. It is hard to see actual changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried ASN1Parser to parse Certificate Data using
SecCertificateCopyNormalizedIssuerSequence, (https://developer.apple.com/documentation/security/2799310-seccertificatecopynormalizedissu)
but the Library crashed.
Same for SecKeyCopyExternalRepresentation (https://developer.apple.com/documentation/security/1643698-seckeycopyexternalrepresentation/)
For the first error I added "Printable String" as DER-Type, for the second I fixed the length calculation. See added Testcase "ParseCertificateTests".
If you like it, please accept pull request.