fix(certificates): ensure certificates are accessible by traefik #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drudge
force-pushed
the
cert-enhancements
branch
from
092079d to
9d0af2c
Compare
drudge
changed the title
drudge
force-pushed
the
cert-enhancements
branch
from
9d0af2c to
56cfd35
Compare
Siumauricio
approved these changes
Dec 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the clarity and functionality of the domain and certificate management components in the
dokployapplication. The most important change is refactoring path handling in the server constants to expose the certificate to a path accessible by the traefik container.Label and placeholder updates:
apps/dokploy/components/dashboard/application/domains/add-domain.tsx: UpdatedFormLabelandSelectValueplaceholders to "Certificate Provider" and "Select a certificate provider" respectively, and changed "Letsencrypt" to "Let's Encrypt".apps/dokploy/components/dashboard/application/preview-deployments/add-preview-domain.tsx: UpdatedFormLabelandSelectValueplaceholders to "Certificate Provider" and "Select a certificate provider" respectively, and changed "Letsencrypt" to "Let's Encrypt".apps/dokploy/components/dashboard/application/preview-deployments/show-preview-settings.tsx: UpdatedFormLabelandSelectValueplaceholders to "Certificate Provider" and "Select a certificate provider" respectively, and changed "Letsencrypt" to "Let's Encrypt".apps/dokploy/components/dashboard/compose/domains/add-domain.tsx: UpdatedFormLabelandSelectValueplaceholders to "Certificate Provider" and "Select a certificate provider" respectively, and changed "Letsencrypt" to "Let's Encrypt".(In a future refactor we should standardize this certificate provider selection component)
Certificate management improvements:
apps/dokploy/components/dashboard/settings/certificates/add-certificate.tsx: Added a new placeholder for private key data and updated theTextareaplaceholder to use this new placeholder. [1] [2]Server constants refactoring:
packages/server/src/constants/index.ts: Refactored thepathsfunction to simplify path handling and ensure the correct paths are used based on the environment.